Skip to content

REF: refactor tests.indexes.base_index::TestIndex #49679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
topper-123 opened this issue Nov 13, 2022 · 1 comment
Closed

REF: refactor tests.indexes.base_index::TestIndex #49679

topper-123 opened this issue Nov 13, 2022 · 1 comment
Labels
Index Related to the Index class or subclasses Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite

Comments

@topper-123
Copy link
Contributor

topper-123 commented Nov 13, 2022 •
edited
Loading

A lot of the tests in tests.indexes.base_index::TestIndexlook like they could like they could be improved to moving them to tests.indexes.common.Base and adapting subclasses as needed. This would give better test coverage.

See discussion in #49678 (comment).
@topper-123 topper-123 added Usage Question Needs Triage Issue that has not been reviewed by a pandas team member Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite Index Related to the Index class or subclasses and removed Usage Question Needs Triage Issue that has not been reviewed by a pandas team member labels Nov 13, 2022
@topper-123 topper-123 mentioned this issue Nov 13, 2022
Merged
@mroeschke
Copy link
Member

Looks like these tests have been refactored in the meantime so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mroeschke @topper-123