-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix styles for dark mode in docs home #48527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@datapythonista May I work on this issue? |
Sure, please do. Thanks @valanm22 |
Do I replace the old svg images or do I upload them as new svg images? |
Better replace the old images. |
Ok got it. |
I'll also try to fix it |
Looks like the problem are not the svg images, but the styles. I updated the description. |
I'm not able to run python make.py HTML showing error module not found: No module named 'pandas._libs.interval |
In the project root run |
That works! Now I will work on the styles and please do close this issue |
Is this issue still open? |
The only thing I see that still doesn't show well in the dark mode is this section: https://pandas.pydata.org/docs/dev/getting_started/index.html#intro-to-pandas We can close this issue when the background of that block is set to dark, and we check that things look good with it. |
Hi I tried visiting the webpage you linked above, but since dark mode isn't released yet, it would be really helpful if you upload a screenshot of the portion to be modified. (willing to work on this issue :)) |
The dark mode is released. If you don't have your browser in dark mode, you can get it with the icon in the right top of the docs. |
oh okay, thanks Can I work on this issue? |
This is my first time working with open source, it would be really helpful if you could guide me to files that need modification. Thanks in advance :) |
Sure, thanks for the help. I think this PR should be similar to https://github.com/pandas-dev/pandas/pull/48572/files You can build the documentation after creating an environment (see https://pandas.pydata.org/docs/dev/development/contributing_environment.html) running the make.py script inside doc/. The development documentation I point to has more detailed information. |
is this issue closed or still open? |
There is a PR open, it'll be merge shortly. But there is #51860, which is related and you can work on if you are looking for something to contribute. |
xref: #42744
We'll be making the pandas documentation have a dark mode soon. But some boxes in the docs home seem to have a white background, instead of a transparent one:
We should remove any custom style that is preventing the dark mode to work properly.
The changes can be tested against this branch to see if they work properly: #48285
The text was updated successfully, but these errors were encountered: