Skip to content

BUG: Incosistent handling of null types by PeriodIndex #46673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
jgmarcel opened this issue Apr 6, 2022 · 2 comments · Fixed by #47780
Closed
2 of 3 tasks

BUG: Incosistent handling of null types by PeriodIndex #46673

jgmarcel opened this issue Apr 6, 2022 · 2 comments · Fixed by #47780
Assignees
Labels
Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Period Period data type

Comments

@jgmarcel
Copy link

jgmarcel commented Apr 6, 2022

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

import pandas as pd
import numpy as np
pd.PeriodIndex(["2022-04-06", "2022-04-07", None], freq='D')
pd.PeriodIndex(["2022-04-06", "2022-04-07", np.nan], freq='D')
pd.PeriodIndex(["2022-04-06", "2022-04-07", pd.NA], freq='D')

Issue Description

The constructor of PeriodIndex correctly handles None and np.nan values in the input data, but fails to handle pd.NA values. Given that the latter is automatically introduced into a Series of which is called astype('string'), this poses a serious limitation to the initalization of PeriodIndex objects from a Series of dtype string.

Expected Behavior

The return value of

pd.PeriodIndex(["2022-04-06", "2022-04-07", pd.NA], freq='D')

should be the same as

pd.PeriodIndex(["2022-04-06", "2022-04-07", None], freq='D')

that is:

PeriodIndex(['2022-04-06', '2022-04-07', 'NaT'], dtype='period[D]')

Installed Versions

INSTALLED VERSIONS
------------------
commit           : 4bfe3d07b4858144c219b9346329027024102ab6
python           : 3.9.6.final.0
python-bits      : 64
OS               : Linux
OS-release       : 5.10.60.1-microsoft-standard-WSL2
Version          : #1 SMP Wed Aug 25 23:20:18 UTC 2021
machine          : x86_64
processor        : x86_64
byteorder        : little
LC_ALL           : None
LANG             : C.UTF-8
LOCALE           : en_US.UTF-8

pandas           : 1.4.2
numpy            : 1.22.3
pytz             : 2021.1
dateutil         : 2.8.2
pip              : 22.0.4
setuptools       : 57.4.0
Cython           : None
pytest           : None
hypothesis       : None
sphinx           : None
blosc            : None
feather          : None
xlsxwriter       : None
lxml.etree       : None
html5lib         : None
pymysql          : None
psycopg2         : 2.9.2
jinja2           : None
IPython          : 7.26.0
pandas_datareader: None
bs4              : None
bottleneck       : None
brotli           :
fastparquet      : None
fsspec           : 2021.07.0
gcsfs            : None
markupsafe       : 2.0.1
matplotlib       : 3.4.3
numba            : None
numexpr          : None
odfpy            : None
openpyxl         : 3.0.9
pandas_gbq       : None
pyarrow          : None
pyreadstat       : None
pyxlsb           : None
s3fs             : 2021.07.0
scipy            : 1.8.0
snappy           : None
sqlalchemy       : 1.4.34
tables           : None
tabulate         : None
xarray           : None
xlrd             : 2.0.1
xlwt             : None
zstandard        : None
@jgmarcel jgmarcel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 6, 2022
@simonjayhawkins simonjayhawkins added the Period Period data type label Jun 5, 2022
@mroeschke mroeschke added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 6, 2022
@kapiliyer
Copy link
Contributor

take

@jgmarcel
Copy link
Author

take

Feel free to ask should you need any further information on this report. Thank you.

mroeschke pushed a commit that referenced this issue Jul 18, 2022
…46409) (#47736)

* TST: add test for last method on dataframe grouped by on boolean column (#46409)

* TST: add test for last method on dataframe grouped by on boolean column (#46409)

* BUG: PeriodIndex fails to handle NA, rather than putting NaT in its place (#46673)

* BUG: PeriodIndex fails to handle NA, rather than putting NaT in its place (#46673)

* BUG: PeriodIndex fails to handle NA, rather than putting NaT in its place (#46673)
mroeschke pushed a commit that referenced this issue Aug 1, 2022
…lace (#46673) (#47780)

* BUG: PeriodIndex fails to handle NA, rather than putting NaT in its place (#46673)

* BUG: PeriodIndex fails to handle NA, rather than putting NaT in its place (#46673)

* BUG: Series.astype is unable to handle pd.nan.

* BUG: PeriodIndex fails to handle NA, rather than putting NaT in its place (#46673)

* BUG: Series.astype is unable to handle pd.nan (#46377)

* BUG: PeriodIndex fails to handle NA, rather than putting NaT in its place (#46673)

* BUG: PeriodIndex fails to handle NA, rather than putting NaT in its place (#46673)

* BUG: PeriodIndex fails to handle NA, rather than putting NaT in its place (#46673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Period Period data type
Projects
None yet
4 participants