Skip to content

ENH: resample.sum documents a numeric_only argument #46442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #46560
rhshadrach opened this issue Mar 20, 2022 · 2 comments · Fixed by #46792
Closed
Tracked by #46560

ENH: resample.sum documents a numeric_only argument #46442

rhshadrach opened this issue Mar 20, 2022 · 2 comments · Fixed by #46792
Labels
Enhancement Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Resample resample method
Milestone
1.5

Comments

@rhshadrach
Copy link
Member

https://pandas.pydata.org/docs/reference/api/pandas.core.resample.Resampler.sum.html

The parameters listed there include numeric_only though it is not in the function signature, and not implemented currently.

@mroeschke - is the right action here just to remove it from the docs?
@rhshadrach rhshadrach added Docs Resample resample method labels Mar 20, 2022
@mroeschke
Copy link
Member

Yes, I would say if the function doesn't accept this argument then numeric_only can just be removed from the docstring

@rhshadrach rhshadrach added this to the Contributions Welcome milestone Mar 20, 2022
@lorentzbao lorentzbao mentioned this issue Apr 17, 2022
Merged
4 tasks
@rhshadrach rhshadrach added Enhancement Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply and removed Docs labels Apr 23, 2022
@rhshadrach rhshadrach modified the milestones: Contributions Welcome, 1.5 Apr 23, 2022
@rhshadrach
Copy link
Member Author

Similar to #46524, I think it'd be better to instead add numeric_only.

@rhshadrach rhshadrach mentioned this issue Apr 23, 2022
Closed
9 tasks
@rhshadrach rhshadrach changed the title resample.sum documents a numeric_only argument ENH: resample.sum documents a numeric_only argument Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Resample resample method
Projects
None yet
Milestone
1.5
Development

Successfully merging a pull request may close this issue.

ENH: Add numeric_only to resampler methods lorentzbao/pandas
2 participants
@mroeschke @rhshadrach