-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Master does not compile on windows #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Cython uses the following macros:
so i'll just use a variant of that. thanks for figuring this out, another user also reported. Proof that I need to get a CI server set up for pandas soon |
Can you verify that all works and the test suite passes? I've been building with mingw32 and not MSVC so am not immediately equipped to test |
I got the MSVC compiler set up in my VM and verified that all's OK now. Tons of compiler warnings ( |
…-dev#250 ) (pandas-dev#460) * Don't re-authenticate with every call to read/access the top level collection, unless connection is reset. Thread-safe. Add arctic_reset method which is called by Store implementation upon init, to force reconnect/re-auth Instead of resetting Arctic connection everytime we instantiate a new Store, only trigger re-authentication for the Databases added multiprocessing safety for Arctic connection and tests make only one getpid call simplified the design, auth is called either at instantiation of the artict top level lib, or if Arctic is reset (explicitly or afer fork) * enhanced the integration tests for arctic, excercised also the reset() * incorporating PR comment, print is not necessary here * PR comment change: don't require/expect from Store implementation to trigger _reset_auth(), trigger it on ArcticLibraryBinding instantiation and whenever Acttic's connection is reset * added integration test to verify re-auth is triggered when Arctic is reset * leftover comment was removed * fixed bug with ArcticLibraryBinding not picking up the arctic reset, improved test coverage, split the multithreading tests to separate files * nicer call count handling in test * added the changes to the change log
I ran into issues compiling current master on windows. The problem is with the new pandas/src/numpyhelper.h file
There are two issues there:
It does support _inline in C however, which has the intended meaning as far as i can tell.
There's a diff below, it only show how to make it compile on windows, and is not portable. I didn't put this in a pull request because i'm not sure how you would like to make changes that are portable.
The text was updated successfully, but these errors were encountered: