Skip to content

ENH: Add observed keyword to value_counts #43498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jseabold opened this issue Sep 10, 2021 · 2 comments
Closed

ENH: Add observed keyword to value_counts #43498

jseabold opened this issue Sep 10, 2021 · 2 comments
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Categorical Categorical Data Type Enhancement

Comments

@jseabold
Copy link
Contributor

Is your feature request related to a problem?

If you do value_counts on a categorical there's no way to suppress unobserved categories.

Describe the solution you'd like

Add an observed keyword to value_counts.

API breaking implications

None, unless we want to revisit the default in light of #35967.
@jseabold jseabold added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 10, 2021
@usersblock
Copy link
Contributor

Hello, is there a code sample you want to add to testing?

@mroeschke mroeschke added Categorical Categorical Data Type and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 30, 2021
AndrewEckart added a commit to AndrewEckart/pandas that referenced this issue Oct 12, 2021
@AndrewEckart
ENH: Support observed keyword argument in Categorical.value_counts (p…
9cf8f79 
…andas-dev#43498)
@AndrewEckart AndrewEckart mentioned this issue Oct 12, 2021
Closed
4 tasks
AndrewEckart added a commit to AndrewEckart/pandas that referenced this issue Oct 12, 2021
@AndrewEckart
ENH: Support observed keyword argument in Categorical.value_counts (p…
b4d4558 
…andas-dev#43498)
AndrewEckart added a commit to AndrewEckart/pandas that referenced this issue Nov 15, 2021
@AndrewEckart
ENH: Support observed keyword argument in Categorical.value_counts (p…
2ff69a3 
…andas-dev#43498)
@LucasG0 LucasG0 mentioned this issue Mar 13, 2022
Closed
3 tasks
@simonjayhawkins simonjayhawkins added the Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff label Jun 11, 2022
@jbrockmendel
Copy link
Member

closing as duplicate of #46486 (even though this came first, there is more discussion there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Categorical Categorical Data Type Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Support observed keyword argument in Categorical.value_counts AndrewEckart/pandas
5 participants
@jseabold @jbrockmendel @mroeschke @usersblock @simonjayhawkins