-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Doctests failing on master #42798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
take |
okay so this issue is actually because a PR #42705 had problems right? So should I make the changes or wait for the PR to be edited? |
Not exactly. Those doctests are broken in master, which means that any PR that we open now, even one with an empty commit, will fail, and we won't be able to merge it. So, the PR for this issue is the first one that should be merged, before we can merge anything else. |
this already has an issue and a PR to fix |
Thanks for the heads up. There is no issue, I see the PR now, didn't see it. @hrishikeshnikam2000 seems like there is a PR for this already. |
Okay I, will make the changes. could you please let me know in which file are we supposed to make the changes?
So should I look into any other issue. I'm sorry its my first Issue in this community |
okay got it |
The next doctests are failing on master, and are breaking the CI. Didn't check what caused the problem, would be good to understand (I guess we merged a PR that wasn't updated). In any case, we should update the output, so the CI is green again:
The next command should report the above errors, and should return clean after the fixes:
./ci/code_checks.sh doctests
The text was updated successfully, but these errors were encountered: