Skip to content

DOC: Readme.md file have some grammatical errors #42447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Varun270 opened this issue Jul 8, 2021 · 7 comments
Closed

DOC: Readme.md file have some grammatical errors #42447

Varun270 opened this issue Jul 8, 2021 · 7 comments
Labels
Docs Needs Triage Issue that has not been reviewed by a pandas team member

Comments

@Varun270
Copy link
Contributor

Varun270 commented Jul 8, 2021

Location of the documentation

README.md file

Documentation problem

There are some unwanted commas and colons with grammatical error

Suggested fix for documentation

The fix is easy just have to grammatically correct the README file.

@Varun270 Varun270 added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 8, 2021
@Varun270
Copy link
Contributor Author

Varun270 commented Jul 8, 2021

I am solving this issue as of now but am facing trouble since I made some changes on the master branch and forgot to create a branch. I haven't staged that updated file. Can anyone tell me what can I do to fix this?

@vladu
Copy link
Contributor

vladu commented Jul 8, 2021

Commit your changes, but don't push. Then create the branch. That will have your changes. Then switch back to master and git reset --hard to the commit just before your first commit that's supposed to be on the branch.

@rhshadrach
Copy link
Member

@Varun270 - Can you specify exactly what the issues are in the readme.

@Varun270
Copy link
Contributor Author

Varun270 commented Jul 8, 2021

@rhshadrach There are some grammatical mistakes , unwanted spaces and commas in README.md

@Varun270
Copy link
Contributor Author

Varun270 commented Jul 8, 2021

@vladu Okay Let me try

@rhshadrach
Copy link
Member

@Varun270 Issues of this nature need to be specific on what the errors are, otherwise a reviewer does not know whether a corresponding PR closes it. It is also okay to submit a PR that doesn't correspond to an issue.

Varun270 added a commit to Varun270/pandas that referenced this issue Jul 9, 2021
@Varun270 Varun270 mentioned this issue Jul 9, 2021
3 tasks
@Varun270
Copy link
Contributor Author

Varun270 commented Jul 9, 2021

@rhshadrach Ohh I am sorry I didn't know that since I am a beginner so I don't really have any idea how exactly things work here. I have generated the PR that resolves this issue. There is a total of 8 changes you can have a look at them.

@Varun270 Varun270 closed this as completed Jul 9, 2021
Varun270 added a commit to Varun270/pandas that referenced this issue Nov 29, 2021
Varun270 added a commit to Varun270/pandas that referenced this issue Nov 29, 2021
Varun270 added a commit to Varun270/pandas that referenced this issue Nov 30, 2021
Varun270 added a commit to Varun270/pandas that referenced this issue Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Needs Triage Issue that has not been reviewed by a pandas team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants