-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix up auto build procedure to upload Cheat Sheet to web site #40949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For the website and docs, we rsync to the server for every commit on master. For example for the website: pandas/.github/workflows/ci.yml Lines 124 to 126 in a25198c
I assume the reason the But adding an additional |
Instead of another rsync, I think we can simply |
Yes, that's indeed even easier. |
I can give this a shot, seems like a good starter issue for a new contributor like me :) I will have to figure out the Github workflows part, but I think I can try for a PR by the weekend. Is there anything else I should know? (Especially as a new contributor to this project?) |
take |
I went through the contribution guidelines and got a good sense of the overall build workflow. I am still a little confused as to where should I Sorry if I am asking obvious questions, but I am unfamiliar with the website build workflows for Pandas overall, so asking what comes to my mind. Would adding the following solve the problem (again, unsure of the destination for the
(this would be added right above Correct me if I have misunderstood anywhere. |
Since the cheatsheet uses a "top-level" URL (it lives directly under pandas.pydata.org), I think it should be copied to
Yes, that seems correct to me (with @Hallicopter Thanks for working on it! |
Not sure, but just came to my mind that maybe we have a nginx rule for the cheatsheets. I remember we had something being served from a different place, and would make sense that are the cheatsheets, otherwise they could be overwritten when updating the web/docs. I'm in a bus the whole day, so can't check until tomorrow. But if that's the case we'll have to synchronize merging the PR with updating nginx. |
Yep, no problem! If I were to locally test my changes, is there any suggestion you have? I can just build the website locally using the commands I am assuming. |
I was just checking, there is nothing in the nginx config. It's just the exclude in the rsync that is being used to avoid them being overwritten. I'm +1 on moving the cheatsheets to their own directory (e.g. In any case, your command seems right (I'd just add |
That's great! I shall put in a PR in a few days for review. Also, for my understanding here
Why are |
@Hallicopter any update on doing a PR for this? |
take |
Need to fix the procedures so that the PDFs (English, Japanese) for the cheat sheet here: https://github.com/pandas-dev/pandas/tree/master/doc/cheatsheet
get uploaded to here:
https://pandas.pydata.org/Pandas_Cheat_Sheet.pdf
(and when the Japanese one is there, can update the docs to link to it as well)
Note: If we decide to move the location on the web site, then we should do a redirect, because there are links out there to the cheat sheet in the current location.
Followup to discussion here: #40168 (comment)
The text was updated successfully, but these errors were encountered: