Skip to content

RLS: 1.2.4 #40168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonjayhawkins opened this issue Mar 2, 2021 · 26 comments
Closed

RLS: 1.2.4 #40168

simonjayhawkins opened this issue Mar 2, 2021 · 26 comments
Labels
Release
Milestone
1.2.4

Comments

@simonjayhawkins
Copy link
Member

Tracking issue for the 1.2.4 release.

https://github.com/pandas-dev/pandas/milestone/84

Currently scheduled for April 01, 2021

List of open regressions: https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3ARegression
@simonjayhawkins simonjayhawkins added this to the 1.2.4 milestone Mar 2, 2021
@jreback
Copy link
Contributor

jreback commented Apr 9, 2021

so there is one open PR, but if any other regressions we want to patch, let's do so pretty soon, then can release

@pandas-dev/pandas-core @pandas-dev/pandas-triage

@simonjayhawkins
Copy link
Member Author

#40878 to be merged. other issues/PRs moved to 1.2.5 https://github.com/pandas-dev/pandas/milestone/85

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Apr 12, 2021 •
edited
Loading

pre-release checklist

@jorisvandenbossche I'll start to run through these now. (can either start again or maybe skip these depending on discussion in #40878

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Apr 12, 2021 •
edited
Loading

starting release now. (and re-running pre-release checks. will not push tag till these have passed)

pre-release checklist

1.2.4 release

@simonjayhawkins
Copy link
Member Author

building the docs is much slower than the previous release. It looks like it is only using one core. will push tag after ci checks on 1.2x are green. (I did a dummy release on Saturday so hopefully no changes that would cause the docs not to build)

@simonjayhawkins
Copy link
Member Author

ci checks completed on 1.2.x but since Travis job took a while the doc build is now at 87% so will wait a little and check the docs before pushing tag.

@jorisvandenbossche
Copy link
Member

building the docs is much slower

Ah, yes, we should maybe have included #40761 (comment) for the 1.2.4 release... Otherwise @simonjayhawkins you can also pin the pydata-sphinx-theme to version 0.5.2 instead of using the latest (which is 0.6.0 right now)

@simonjayhawkins
Copy link
Member Author

docs built and uploaded. will add 1.2.5 milestone #40761

@simonjayhawkins
Copy link
Member Author

@jorisvandenbossche I recall some issue with caching on the web server in the past. the docs are OK at https://pandas.pydata.org/pandas-docs/version/1.2.4/ but don't look right at https://pandas.pydata.org/docs/

does this sort itself out or some action needed?

@simonjayhawkins
Copy link
Member Author

@jorisvandenbossche I recall some issue with caching on the web server in the past. the docs are OK at https://pandas.pydata.org/pandas-docs/version/1.2.4/ but don't look right at https://pandas.pydata.org/docs/

does this sort itself out or some action needed?

seems ok now.

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Apr 13, 2021 •
edited
Loading

conda-forge/pandas-feedstock#110 (comment)

pypy build on drone completed in around 30 mins here on this PR but was killed at the hour mark on the commit.

I can't see where on the drone console where the job can be restarted @jorisvandenbossche @jreback @TomAugspurger

https://cloud.drone.io/conda-forge/pandas-feedstock/116

@bashtage
Copy link
Contributor

Top right.

image

@simonjayhawkins
Copy link
Member Author

Thanks @bashtage wasn't logged in!

@jorisvandenbossche
Copy link
Member

I recall some issue with caching on the web server in the past.

The underlying issue that we experienced a while ago should be fixed (the CSS file now has a hash in the file name, so whenever there is a change in the CSS, the name changes and browser/server shouldn't incorrectly cache it).

(but so if you would still notice it later, certainly report it!)

@rhshadrach
Copy link
Member

@jorisvandenbossche - When I clicked on the https://pandas.pydata.org/docs/ link above, I had to refresh the page for the CSS to properly render. Don't know if it as a cache issue or just a glitch.

@simonjayhawkins
Copy link
Member Author

all conda builds now successful and packages available on conda-forge (including aarch64)

@jorisvandenbossche
Copy link
Member

Thanks Simon!

When I clicked on the https://pandas.pydata.org/docs/ link above, I had to refresh the page for the CSS to properly render. Don't know if it as a cache issue or just a glitch.

@rhshadrach yeah, not fully sure (no expert in this area). In any case, the original issue is solved in the theme, so it might be normal that you still might need a refresh for your local cache (the previous time, it was actually the server that was caching it as well, and a local browser refresh didn't automatically solve that)

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Apr 14, 2021

Not sure how this works, but there were some updates to the cheat sheet (https://pandas.pydata.org/Pandas_Cheat_Sheet.pdf) available from https://github.com/pandas-dev/pandas/blob/master/doc/cheatsheet/Pandas_Cheat_Sheet.pdf that I merged in a couple of weeks ago, and I don't think they got pushed out to the server.

@simonjayhawkins
Copy link
Member Author

The docs are built from the backport branch.

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Apr 14, 2021

The docs are built from the backport branch.

The concern here is that the cheat sheet isn't in the normal docs hierarchy at https://pandas.pydata.org/docs/

@simonjayhawkins
Copy link
Member Author

Is it available on the dev docs https://pandas.pydata.org/pandas-docs/dev/index.html

@jorisvandenbossche
Copy link
Member

@simonjayhawkins you might be talking about the pdf docs, and not the pdf cheatsheet? (as I don't see that linked on the docs home page)

@Dr-Irv the cheatsheet is linked at the bottom of https://pandas.pydata.org/pandas-docs/dev/getting_started/index.html, but it should probably get a more prominent place (feel free to open an issue about that, since it is not related to the release)

But so you are saying that https://pandas.pydata.org/Pandas_Cheat_Sheet.pdf isn't the latest version (so the one at https://github.com/pandas-dev/pandas/blob/master/doc/cheatsheet/Pandas_Cheat_Sheet.pdf has newer changes)? I also don't directly know how this is synced with the server. The website is synced with the github actions workflow, but the cheatsheet might not be included there.

@simonjayhawkins
Copy link
Member Author

@simonjayhawkins you might be talking about the pdf docs, and not the pdf cheatsheet? (as I don't see that linked on the docs home page)

sorry I meant https://pandas.pydata.org/pandas-docs/dev/, the index.html is the default.

shouldn't the cheatsheet be under a version branch instead of at the top level?

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Apr 14, 2021

@jorisvandenbossche

@Dr-Irv the cheatsheet is linked at the bottom of https://pandas.pydata.org/pandas-docs/dev/getting_started/index.html, but it should probably get a more prominent place (feel free to open an issue about that, since it is not related to the release)

I'm fine with where the link is, but the link is to https://pandas.pydata.org/Pandas_Cheat_Sheet.pdf so there needs to be something that regularly updates that top level PDF with what is in the repo.

But so you are saying that https://pandas.pydata.org/Pandas_Cheat_Sheet.pdf isn't the latest version (so the one at https://github.com/pandas-dev/pandas/blob/master/doc/cheatsheet/Pandas_Cheat_Sheet.pdf has newer changes)?

Yes, that is correct. The one in the GitHub repo is the latest.

I also don't directly know how this is synced with the server. The website is synced with the github actions workflow, but the cheatsheet might not be included there.

We had some issue with this some time ago, and I don't know what happened on the back end to automate the process. See discussion here: #20366 (comment)

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Apr 14, 2021

shouldn't the cheatsheet be under a version branch instead of at the top level?

Decision was made and discussed here: #20366 (comment)

Certainly worthwhile to consider moving it, although I think there are now people who link to the cheat sheet at its current location, so if it is moved, we may have to add a redirect to the site.

@simonjayhawkins
Copy link
Member Author

presumably the top level link should be linked to 'stable' branch which is the latest release.

@Dr-Irv Dr-Irv mentioned this issue Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Release
Projects
None yet
Milestone
1.2.4
Development

No branches or pull requests
6 participants
@jreback @jorisvandenbossche @bashtage @simonjayhawkins @Dr-Irv @rhshadrach