Skip to content

CI: failing numpy_dev 3.8 build #40144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Mar 1, 2021 · 8 comments · Fixed by #40212
Closed

CI: failing numpy_dev 3.8 build #40144

jreback opened this issue Mar 1, 2021 · 8 comments · Fixed by #40212
Labels
CI Continuous Integration Groupby Testing pandas testing functions or related to the test suite Upstream issue Issue related to pandas dependency
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Mar 1, 2021

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=55190&view=logs&j=eab14f69-13b6-5db7-daeb-7b778629410b&t=ce687173-08c6-5301-838d-71b2dda24510

__________________ TestGroupby.test_groupby_apply_identity ____________________
[gw0] linux -- Python 3.8.8 /home/vsts/miniconda3/envs/pandas-dev/bin/python

>   raise TypeError("boolean value of NA is ambiguous")
E   TypeError: boolean value of NA is ambiguous

pandas/_libs/missing.pyx:436: TypeError

The above exception was the direct cause of the following exception:

self = <pandas.tests.extension.test_boolean.TestGroupby object at 0x7f9eb07e2bb0>
data_for_grouping = <BooleanArray>
[True, True, <NA>, <NA>, False, False, True]
Length: 7, dtype: boolean

    def test_groupby_apply_identity(self, data_for_grouping):
        df = pd.DataFrame({"A": [1, 1, 2, 2, 3, 3, 1], "B": data_for_grouping})
        result = df.groupby("A").B.apply(lambda x: x.array)
        expected = pd.Series(
            [
                df.B.iloc[[0, 1, 6]].array,
                df.B.iloc[[2, 3]].array,
                df.B.iloc[[4, 5]].array,
            ],
            index=pd.Index([1, 2, 3], name="A"),
            name="B",
        )
>       self.assert_series_equal(result, expected)

pandas/tests/extension/test_boolean.py:335: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
@jreback jreback added Testing pandas testing functions or related to the test suite Groupby CI Continuous Integration labels Mar 1, 2021
@jreback jreback added this to the 1.3 milestone Mar 1, 2021
@jreback
Copy link
Contributor Author

jreback commented Mar 1, 2021

cc @pandas-dev/pandas-core

@simonjayhawkins
Copy link
Member

changed milestone to 1.2.3 as also failing on 1.2.x branch. https://github.com/pandas-dev/pandas/runs/1998469459

@jreback
Copy link
Contributor Author

jreback commented Mar 1, 2021

cc @rhshadrach

@jorisvandenbossche
Copy link
Member

@simonjayhawkins since this is only about numpy master (and they don't plan to release any time soon, they just had a release), I don't think this should be blocking 1.2.3 (still be useful for 1.2.x in general if there is a fix, of course)

@simonjayhawkins
Copy link
Member

agree. see #40143 (comment). will start release tomorrow regardless.

@simonjayhawkins simonjayhawkins modified the milestones: 1.2.3, 1.2.4 Mar 2, 2021
@jreback
Copy link
Contributor Author

jreback commented Mar 2, 2021

@jbrockmendel is this failure on numpy_dev build different that what you were discussing with @seberg ? (can't remember where that convo was).

can we xfail these temporarily to make CI green.

@jbrockmendel
Copy link
Member

Its the same thing as #40158. IIUC seberg is on top of it.

@lithomas1 lithomas1 added the Upstream issue Issue related to pandas dependency label Mar 2, 2021
jbrockmendel added a commit to jbrockmendel/pandas that referenced this issue Mar 2, 2021
@seberg
Copy link
Contributor

seberg commented Mar 2, 2021

Allen made a PR here: numpy/numpy#18530 that should be fine (there is another small potential thing, but I doubt you hit that).

fangchenli added a commit to fangchenli/pandas that referenced this issue Mar 4, 2021
@jreback jreback modified the milestones: 1.2.4, 1.3 Mar 4, 2021
jreback pushed a commit that referenced this issue Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Groupby Testing pandas testing functions or related to the test suite Upstream issue Issue related to pandas dependency
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants