Skip to content

CI upgrade pyupgrade #39523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue Feb 1, 2021 · 1 comment · Fixed by #39538
Closed

CI upgrade pyupgrade #39523

MarcoGorelli opened this issue Feb 1, 2021 · 1 comment · Fixed by #39538
Assignees
@gunjan-solanki
Labels
CI Continuous Integration Code Style Code style, linting, code_checks good first issue

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Feb 1, 2021 •
edited
Loading

Issue here is:

  1. in .pre-commit-config.yaml, change the ref of pyupgrade from v2.7.4 to v2.9.0
  2. run pre-commit run pyupgrade --all-files
  3. run pre-commit run flake8 --all-files - there will be lots of errors from unused imports, so you should remove them (or you could look into using autoflake to do it for you)
  4. if both pre-commit run flake8 --all-files and pre-commit run pyupgrade --all-files both pass, then open a pull request 🚀

xref #39521
@MarcoGorelli MarcoGorelli added CI Continuous Integration Code Style Code style, linting, code_checks good first issue labels Feb 1, 2021
@gunjan-solanki
Copy link
Contributor

take

@gunjan-solanki gunjan-solanki mentioned this issue Feb 1, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gunjan-solanki gunjan-solanki

Labels
CI Continuous Integration Code Style Code style, linting, code_checks good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Upgrade 'pyupgrade' (v2.7.4 --> v2.9.0) gunjan-solanki/pandas
2 participants
@MarcoGorelli @gunjan-solanki