-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TYP: Mypy failures with new numpy #39513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
#36092 is basically doing that (needs an update) in the short term we should just pin numpy on ci and checks while we discuss. another option could be remove any problematic type annotations from type signature, return types or variable annotations, they are likely incorrect in some cases which is why mypy is reporting errors |
#39526 has been backported to get ci green on 1.2.x but that PR changes environment.yaml. I don't think we want to release with that change, so labelled as blocker for now. |
moving to 1.2.3. will be merging #39641 before 1.2.2 release to avoid blocking. |
#39998 disables checking site packages (i.e. numpy and pytest) so no longer a blocker to 1.2.x releases, have removed the blocker tag, but will want to sort this before 1.3. |
merged that so will close this issue and open a new issue for the fix-up |
Mypy raises a lot of errors since the new numpy is available on conda-forge. What is the best approach here? Adding ignores for everything and fixing them step by step afterwards?
cc @simonjayhawkins
The text was updated successfully, but these errors were encountered: