Skip to content

BUG: Repeated key words on datetime indexing methods (_parsed_string_to_bounds()) #39503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
boringow opened this issue Jan 31, 2021 · 1 comment · Fixed by #39506
Closed
3 tasks done

BUG: Repeated key words on datetime indexing methods (_parsed_string_to_bounds()) #39503

boringow opened this issue Jan 31, 2021 · 1 comment · Fixed by #39506

Comments

@boringow
Copy link

boringow commented Jan 31, 2021

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.


Note: Please read this guide detailing how to provide the necessary information for us to reproduce your bug.
Readed! I will know for next time

Code Sample, a copy-pastable example

There is no need for code, as the error is on the function having repeated keywords.

Problem description

There are two repeated keywords on the master/pandas/core/indexes/datetimes.py#L560 and #L561.
I closed the issue #38121, as it is working fine, but as said, there are repeated keywords.

    valid_resos = {
        "year",
        "month",
        "quarter",
        "day",
        "hour",
        "minute",
        "second",
        "minute",
        "second",
        "millisecond",
        "microsecond",
    }

it should be:

    valid_resos = {
        "year",
        "month",
        "quarter",
        "day",
        "hour",
        "minute",
        "second",
        "millisecond",
        "microsecond",
    }

Reference here:

"minute",
"second",

Expected Output

    valid_resos = {
        "year",
        "month",
        "quarter",
        "day",
        "hour",
        "minute",
        "second",
        "millisecond",
        "microsecond",
    }

Output of pd.show_versions()

There is no need for versions. Pandas code in this case is fine. Just two repeated lines.

@boringow boringow added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 31, 2021
@MarcoGorelli MarcoGorelli added Clean good first issue and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 31, 2021
@MarcoGorelli MarcoGorelli added this to the Contributions Welcome milestone Jan 31, 2021
@boringow
Copy link
Author

yayy! @MarcoGorelli my first ever contribution to any library!

@phofl phofl modified the milestones: Contributions Welcome, 1.3 Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants