Skip to content

RLS: 1.2.2 #39295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonjayhawkins opened this issue Jan 20, 2021 · 19 comments
Closed

RLS: 1.2.2 #39295

simonjayhawkins opened this issue Jan 20, 2021 · 19 comments
Labels
Release
Milestone
1.2.2

Comments

@simonjayhawkins
Copy link
Member

Tracking issue for the 1.2.2 release.

https://github.com/pandas-dev/pandas/milestone/82

Currently scheduled for February 07, 2021

List of open regressions: https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3ARegression
@simonjayhawkins simonjayhawkins added this to the 1.2.2 milestone Jan 20, 2021
@simonjayhawkins simonjayhawkins mentioned this issue Feb 2, 2021
Closed
@simonjayhawkins
Copy link
Member Author

This is a calendar release scheduled for today.

there are some open PRs milestoned 1.2.2 https://github.com/pandas-dev/pandas/pulls?q=is%3Aopen+is%3Apr+milestone%3A1.2.2

some are close to being ready. Please comment if the release should block on any of these.

cc @jreback @jorisvandenbossche

@jreback
Copy link
Contributor

jreback commented Feb 7, 2021

will look soon

@simonjayhawkins
Copy link
Member Author

no problem. I think all are ready be merged except #39615

@jreback
Copy link
Contributor

jreback commented Feb 7, 2021

yep ok with pushing that off if you would like to do the release. can move all issues to 1.2.3

@simonjayhawkins
Copy link
Member Author

sure. won't move any issues till backports are complete and MacPython/pandas-wheels#126 is merged and green (currently failing on PR)

@rhshadrach
Copy link
Member

@simonjayhawkins @jreback I've updated #39547 and it is ready on my end. It would be great if this could get into 1.2.2 but certainly okay if it waits till 1.2.3.

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Feb 8, 2021 •
edited
Loading

pre-release checklist

current status:

5 open PRs. https://github.com/pandas-dev/pandas/pulls?q=is%3Aopen+is%3Apr+milestone%3A1.2.2

#39641 will be merged last

will open a PR shortly for the release date (and clear the empty list items which will create a conflict with #39547).

will also start moving the remaining issues off the milestone shortly, after MacPython/pandas-wheels#125 completes. (nightlies built ok, so 1.2.x should be the same)

@simonjayhawkins
Copy link
Member Author

will also start moving the remaining issues off the milestone shortly, after MacPython/pandas-wheels#125 completes. (nightlies built ok, so 1.2.x should be the same)

green

@simonjayhawkins
Copy link
Member Author

since azure is so slow, i'm thinking of cancelling some workflows. this may backfire if the last commit fails and it's not obvious which commit caused the failure.

I think that if we wait for them to complete, by the time we've done the pre-release checklist, we won't be releasing today.

I'm ok with doing release tomorrow though.

@simonjayhawkins
Copy link
Member Author

one thing to note. to avoid uploading the docs we don't run Github actions on the commits to 1.2.x. Now that there are many other jobs run on Github actions we should revisit this and not just rely on the ci for the backport PR.

@jreback
Copy link
Contributor

jreback commented Feb 8, 2021

@simonjayhawkins all sounds good. do what you need to do. possibly enhance the release docs with tips like these at some point.

@simonjayhawkins
Copy link
Member Author

will be patient and leave the release till tomorrow.

our release docs don't have anything about preparing for the release. for this reason I use the release tracking issue (i.e. this one) to document each step and progress.

for the Github actions issue, I should open a new issue and xref #38360. we may want to activate Github actions for pushes to 1.2.x and update .github\workflows\ci.yml which will currently upload docs on a push event...

    - name: Upload web
      run: rsync -az --delete --exclude='pandas-docs' --exclude='docs' --exclude='Pandas_Cheat_Sheet*' web/build/ docs@${{ secrets.server_ip }}:/usr/share/nginx/pandas
      if: github.event_name == 'push'

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Feb 8, 2021 •
edited
Loading

final pre-release checklist

@simonjayhawkins
Copy link
Member Author

pre-release checks passed. will be starting release tomorrow assuming no commits to 1.2.x or PRs/issues milestoned 1.2.2 in the meantime.

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Feb 9, 2021 •
edited
Loading

starting release now.

@simonjayhawkins simonjayhawkins mentioned this issue Feb 9, 2021
Closed
@simonjayhawkins
Copy link
Member Author

aarch 3.8 and 3.9 wheels also built.

@simonjayhawkins
Copy link
Member Author

The web-page https://pandas.pydata.org/ gets updated after a commit to master.

will change the order next time, and leave the committing of the starting of the new release notes till after the github release, so there is something to commit to master.

@simonjayhawkins
Copy link
Member Author

linux_aarch64_numpy1.19python3.7.____73_pypy passed on the PR and failed on the push, restarted.

@jorisvandenbossche
Copy link
Member

Thanks Simon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Release
Projects
None yet
Milestone
1.2.2
Development

No branches or pull requests
4 participants
@jreback @jorisvandenbossche @simonjayhawkins @rhshadrach