Skip to content

TST: dropping of nuisance columns for groupby ops #38815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhshadrach opened this issue Dec 30, 2020 · 2 comments · Fixed by #43674
Closed

TST: dropping of nuisance columns for groupby ops #38815

rhshadrach opened this issue Dec 30, 2020 · 2 comments · Fixed by #43674
Assignees
@horaceklai
Labels
Groupby Needs Tests Unit test(s) needed to prevent regressions Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply
Milestone
1.4

Comments

@rhshadrach
Copy link
Member

xref #38774

As far as I can tell, for groupby we only have two tests for dropping nuisance columns and these only involve sum/mean. A more robust and parameterized test over all the groupby ops that drop nuisance columns should be added.
@rhshadrach rhshadrach added Groupby Needs Tests Unit test(s) needed to prevent regressions Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply labels Dec 30, 2020
@rhshadrach rhshadrach added this to the Contributions Welcome milestone Dec 30, 2020
@rhshadrach rhshadrach mentioned this issue Dec 30, 2020
Merged
5 tasks
@horaceklai
Copy link
Contributor

take

@horaceklai
Copy link
Contributor

Is there a list of aggregation functions where nuisance columns are dropped?

I expected functions such as max, min, last, first to drop columns of object datatypes. But I was wrong.

So far I have mean, sum, std, var, sem

@horaceklai horaceklai mentioned this issue Sep 20, 2021
Merged
1 task
@jreback jreback modified the milestones: Contributions Welcome, 1.4 Sep 21, 2021
jreback pushed a commit that referenced this issue Oct 5, 2021
@horaceklai
TST: dropping of nuisance columns for groupby ops #38815 (#43674)
3494078
gasparitiago pushed a commit to gasparitiago/pandas that referenced this issue Oct 9, 2021
@horaceklai @gasparitiago
TST: dropping of nuisance columns for groupby ops pandas-dev#38815 (p…
682d466 
…andas-dev#43674)
rhshadrach pushed a commit to rhshadrach/pandas that referenced this issue Oct 10, 2021
@horaceklai @rhshadrach
TST: dropping of nuisance columns for groupby ops pandas-dev#38815 (p…
005598c 
…andas-dev#43674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@horaceklai horaceklai

Labels
Groupby Needs Tests Unit test(s) needed to prevent regressions Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

TST: dropping of nuisance columns for groupby ops #38815 horaceklai/pandas
3 participants
@jreback @horaceklai @rhshadrach