Skip to content

TST/BUG: Unexpected warnings causing failures on master with fixed assert_produces_warnings(None) behavior #38630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 4 tasks
mzeitlin11 opened this issue Dec 22, 2020 · 6 comments
Closed
1 of 4 tasks

TST/BUG: Unexpected warnings causing failures on master with fixed assert_produces_warnings(None) behavior #38630

mzeitlin11 opened this issue Dec 22, 2020 · 6 comments
Labels
Bug Index Related to the Index class or subclasses Master Tracker High level tracker for similar issues Numeric Operations Arithmetic, Comparison, and Logical operations Warnings Warnings that appear or should be added to pandas

Comments

@mzeitlin11
Copy link
Member

mzeitlin11 commented Dec 22, 2020 •
edited
Loading

xref #38626 (comment)

Making sure assert_produces_warning(None) raises if a warning is emitted gives the following failures in master due to unexpected warnings:

FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-'UTC']
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-'US/Eastern']
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-'Asia/Tokyo']
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-'dateutil/US/Pacific']
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-'dateutil/Asia/Singapore']
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-'+01:15']
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-'-02:15']
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-'UTC+01:15']
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-'UTC-02:15']
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-tzutc()]
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-tzlocal()]
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-pytz.FixedOffset(300)]
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-<UTC>]
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-pytz.FixedOffset(-300)]
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-datetime.timezone.utc]
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-datetime.timezone(datetime.timedelta(seconds=3600))]
FAILED pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array[DataFrame-datetime.timezone(datetime.timedelta(days=-1, seconds=82800), 'foo')]
FAILED pandas/tests/frame/test_arithmetic.py::TestFrameArithmetic::test_binop_other[add-True-bool]
FAILED pandas/tests/frame/test_arithmetic.py::TestFrameArithmetic::test_binop_other[mul-True-bool]
FAILED pandas/tests/indexes/test_common.py::TestCommon::test_asi8_deprecation[int]
FAILED pandas/tests/indexes/test_common.py::TestCommon::test_asi8_deprecation[uint]
FAILED pandas/tests/indexes/test_common.py::TestCommon::test_asi8_deprecation[range]
FAILED pandas/tests/indexes/test_common.py::TestCommon::test_asi8_deprecation[repeats]

Tests which have been xfailed in #38626 are:

  • pandas/tests/arithmetic/test_timedelta64.py::TestTimedelta64ArithmeticUnsorted::test_tda_add_dt64_object_array
  • pandas/tests/frame/test_arithmetic.py::TestFrameArithmetic::test_binop_other
  • pandas/tests/indexes/test_common.py::TestCommon::test_asi8_deprecation
  • pandas/tests/io/parser/test_common.py::test_chunks_have_consistent_numerical_type
@mzeitlin11 mzeitlin11 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 22, 2020
@mzeitlin11
Copy link
Member Author

Also seeing occasional ResourceWarning from pandas/tests/io/parser/test_common.py::test_chunks_have_consistent_numerical_type[python]

@arw2019 arw2019 added Warnings Warnings that appear or should be added to pandas Index Related to the Index class or subclasses Numeric Operations Arithmetic, Comparison, and Logical operations Master Tracker High level tracker for similar issues and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 22, 2020
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this issue Dec 22, 2020
@simonjayhawkins
code sample for pandas-dev#38630
27309bf
@jreback jreback added this to the 1.3 milestone Dec 22, 2020
@jbrockmendel jbrockmendel mentioned this issue Feb 22, 2021
Merged
4 tasks
@simonjayhawkins
Copy link
Member

@jbrockmendel did #39964 close this?

@jbrockmendel
Copy link
Member

i dont think so

@simonjayhawkins
Copy link
Member

OK not sure where the milestone came from. will remove.

@simonjayhawkins simonjayhawkins removed this from the 1.3 milestone Jun 11, 2021
@jbrockmendel
Copy link
Member

@mroeschke might have been addressed by one of your recent PRs?

@mroeschke
Copy link
Member

Yeah I think these no longer exist on main so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Index Related to the Index class or subclasses Master Tracker High level tracker for similar issues Numeric Operations Arithmetic, Comparison, and Logical operations Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jreback @jbrockmendel @mroeschke @simonjayhawkins @mzeitlin11 @arw2019