ENH: add ignore_index to DataFrame / Series.sample

[erfannariman]

Is your feature request related to a problem?

When sampling a dataframe / series we get the original index back by default, which is good, but we should add an option to ignore the index to keep it consistent with other methods like drop_duplicates and explode for example.

Describe the solution you'd like

Add ignore_index argument to Series/DataFrame.sample.

API breaking implications

None as far as I can tell.

df = pd.DataFrame(
    {"col1": range(10, 20), "col2": range(20, 30), "colString": ["a"] * 10}
)
df.sample(n=3, ignore_index=True)

   col1  col2 colString
0    14    24         a
1    17    27         a
2    11    21         a

[skvrahul]

take

[skvrahul]

@erfannariman Doesn't reset_index serve the same purpose in this case?
i.e

df.sample(n=3).reset_index()

[erfannariman]

I actually wanted to work on this if you don't mind. I was waiting till one of the core devs approved the change.

[jreback]

yep this is ok to do

[erfannariman]

Thanks @jreback , @skvrahul you mind if I pick this one up? My bad I didn't "take" before.

[skvrahul]

Thanks @jreback , @skvrahul you mind if I pick this one up? My bad I didn't "take" before.

Sure. No worries! :)
I've unassigned myself

[erfannariman]

take