Skip to content

CI: SQL tests on py38 slow build #38429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fangchenli opened this issue Dec 12, 2020 · 4 comments
Closed

CI: SQL tests on py38 slow build #38429

fangchenli opened this issue Dec 12, 2020 · 4 comments
Labels
CI Continuous Integration IO SQL to_sql, read_sql, read_sql_query Needs Discussion Requires discussion from core team before further action

Comments

@fangchenli
Copy link
Member

fangchenli commented Dec 12, 2020 •
edited
Loading

In #38344, we found that SQL tests were not run on py38 slow build. Currently, we are testing SQL on py37-locale and py37-coverage. If that is enough, we could move py38-slow to Azure. Otherwise, we could add more builds for SQL.
@fangchenli fangchenli added Bug Needs Triage Issue that has not been reviewed by a pandas team member CI Continuous Integration and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 12, 2020
@simonjayhawkins simonjayhawkins added the Needs Discussion Requires discussion from core team before further action label Dec 13, 2020
@fangchenli fangchenli mentioned this issue Dec 17, 2020
Merged
fangchenli pushed a commit to fangchenli/pandas that referenced this issue Dec 21, 2020
CI: move py38 slow to azure pandas-dev#38429
4b002c2
@fangchenli fangchenli mentioned this issue Dec 21, 2020
Merged
jreback pushed a commit that referenced this issue Dec 21, 2020
@fangchenli
CI: move py38 slow to azure #38429 (#38613)
f957b0c 
Co-authored-by: VirosaLi <2EkF8qUgpNkj>
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this issue Dec 21, 2020
@fangchenli @meeseeksmachine
Backport PR pandas-dev#38613: CI: move py38 slow to azure pandas-dev#…
9059c1f 
…38429
@meeseeksmachine meeseeksmachine mentioned this issue Dec 21, 2020
Merged
jreback pushed a commit that referenced this issue Dec 21, 2020
@meeseeksmachine @fangchenli
Backport PR #38613: CI: move py38 slow to azure #38429 (#38624)
8d4b946 
Co-authored-by: Fangchen Li <[email protected]>
@jreback
Copy link
Contributor

jreback commented Dec 27, 2020

this is closed by #38613 right?

@fangchenli
Copy link
Member Author

this is closed by #38613 right?

If we've decided to not test SQL on py38 slow, this can be closed.

@jreback
Copy link
Contributor

jreback commented Dec 28, 2020

can u see how much slow sql tests we have - meaning are we testing slow sql in at least 1 build?

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this issue Jan 20, 2021
@fangchenli @luckyvs1
CI: move py38 slow to azure pandas-dev#38429 (pandas-dev#38613)
c4ed492 
Co-authored-by: VirosaLi <2EkF8qUgpNkj>
@mroeschke mroeschke added the IO SQL to_sql, read_sql, read_sql_query label Aug 14, 2021
@mroeschke
Copy link
Member

We're testing SQL in GHA on Linux for PY3.8/3.9/3.10, so we have sufficient coverage now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration IO SQL to_sql, read_sql, read_sql_query Needs Discussion Requires discussion from core team before further action
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jreback @fangchenli @mroeschke @simonjayhawkins