Skip to content

REF/CLN: DataFrame.combine_first #38174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arw2019 opened this issue Nov 30, 2020 · 2 comments
Open

REF/CLN: DataFrame.combine_first #38174

arw2019 opened this issue Nov 30, 2020 · 2 comments
Labels
DataFrame DataFrame data structure Refactor Internal refactoring of code

Comments

@arw2019
Copy link
Member

arw2019 commented Nov 30, 2020

xref #38145 (comment)

DataFrame.combine_first should be refactored to use BlockManager.where instead of pandas.core.computation.expressions.where
@arw2019 arw2019 added Bug Needs Triage Issue that has not been reviewed by a pandas team member DataFrame DataFrame data structure Refactor Internal refactoring of code labels Nov 30, 2020
@rhshadrach rhshadrach removed the Needs Triage Issue that has not been reviewed by a pandas team member label Nov 30, 2020
@Abhi-H
Copy link
Contributor

Abhi-H commented Dec 4, 2020

take

@Abhi-H Abhi-H removed their assignment Dec 6, 2020
@simonjayhawkins simonjayhawkins added this to the Contributions Welcome milestone Dec 14, 2020
@hydratedguy
Copy link
Contributor

take

@hydratedguy hydratedguy mentioned this issue Jun 19, 2022
Closed
2 tasks
@hydratedguy hydratedguy removed their assignment Aug 1, 2022
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
RufflesV added a commit to RufflesV/pandas that referenced this issue Oct 27, 2023
@RufflesV
REF: combine_first blockmanager.where frame.py
6bb5a67 
Trying to solve REF/CLN pandas-dev#38174, it passes the first standard test, but not the others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DataFrame DataFrame data structure Refactor Internal refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REF: GH38174 - Refactoring DataFrame.combine_first
6 participants
@mroeschke @simonjayhawkins @Abhi-H @hydratedguy @rhshadrach @arw2019