Skip to content

Update flake8 to 3.8.4 in pre-commit-config.yaml #36879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue Oct 5, 2020 · 1 comment · Fixed by #36882
Closed

Update flake8 to 3.8.4 in pre-commit-config.yaml #36879

MarcoGorelli opened this issue Oct 5, 2020 · 1 comment · Fixed by #36882
Assignees
@Tazminia
Labels
Code Style Code style, linting, code_checks good first issue

Comments

@MarcoGorelli
Copy link
Member

Steps here are:

  • upgrade flake8 in .pre-commit-config.yaml
  • run pre-commit run flake8 --all

If everything passes, open a PR. If there's some error, let us know

Comment take if you want to work on this
@MarcoGorelli MarcoGorelli added Code Style Code style, linting, code_checks good first issue labels Oct 5, 2020
@Tazminia
Copy link
Contributor

Tazminia commented Oct 5, 2020

take

@MarcoGorelli MarcoGorelli mentioned this issue Oct 5, 2020
Merged
Tazminia added a commit to Tazminia/pandas that referenced this issue Oct 8, 2020
@Tazminia
fixes issue pandas-dev#36879
6b0b814
@Tazminia Tazminia mentioned this issue Oct 8, 2020
Merged
MarcoGorelli added a commit that referenced this issue Oct 8, 2020
@Tazminia @TomAugspurger @MarcoGorelli
CI Upgrade isort in pre-commit (#36978)
028eecb 
* fixes issue #36879

* Fixup

* sort pxd files

Co-authored-by: Tom Augspurger <[email protected]>
Co-authored-by: Marco Gorelli <[email protected]>
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
@Tazminia @TomAugspurger @MarcoGorelli
CI Upgrade isort in pre-commit (pandas-dev#36978)
79e5fc0 
* fixes issue pandas-dev#36879

* Fixup

* sort pxd files

Co-authored-by: Tom Augspurger <[email protected]>
Co-authored-by: Marco Gorelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tazminia Tazminia

Labels
Code Style Code style, linting, code_checks good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade flake8 to 3.8.4 #36879
2 participants
@MarcoGorelli @Tazminia