Skip to content

DEPS: drop 3.6 #34472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue May 29, 2020 · 6 comments · Fixed by #35214
Closed

DEPS: drop 3.6 #34472

jreback opened this issue May 29, 2020 · 6 comments · Fixed by #35214
Labels
Dependencies Required and optional dependencies
Milestone
1.2

Comments

@jreback
Copy link
Contributor

jreback commented May 29, 2020

according to schedule we should 3.6 in june 2020

https://numpy.org/neps/nep-0029-deprecation_policy.html

prob ok to keep for the 1.1 release then should drop for 1.2. we will likely be adding. 3.9 support so this makes sense.
@jreback jreback added the Dependencies Required and optional dependencies label May 29, 2020
@jreback jreback added this to the 1.2 milestone May 29, 2020
@simonjayhawkins simonjayhawkins modified the milestones: 1.2, 1.0.4 May 30, 2020
@alimcmaster1
Copy link
Member

Happy to help here when the time comes :)

fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 10, 2020
@fangchenli
DEPS: drop 3.6 (pandas-dev#34472)
ebd254d
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 10, 2020
@fangchenli
DEPS: drop 3.6 (pandas-dev#34472)
71d950d
@fangchenli fangchenli mentioned this issue Jul 10, 2020
Merged
4 tasks
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 10, 2020
@fangchenli
DEPS: fix file name (pandas-dev#34472)
15cd795
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 10, 2020
@fangchenli
DEPS: fix import (pandas-dev#34472)
45ff57f
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 10, 2020
@fangchenli
DEPS: fix job name (pandas-dev#34472)
d6ccbaf
@simonjayhawkins
Copy link
Member

prob ok to keep for the 1.1 release then should drop for 1.2. we will likely be adding. 3.9 support so this makes sense.

we had a discussion about Python version support in #28415, so if doing this we need to update the version policy https://pandas.pydata.org/docs/development/policies.html#python-support

fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 10, 2020
@fangchenli
DEPS: resolve min version conflicts (pandas-dev#34472)
ef13449
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 10, 2020
@fangchenli
DEPS: fix env name (pandas-dev#34472)
d46c764
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 10, 2020
@fangchenli
DEPS: remove py36 check in test, bump matplotlib (pandas-dev#34472)
07dea22
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 10, 2020
@fangchenli
DEPS: fix travis 37 locale (pandas-dev#34472)
2f9299f
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 10, 2020
@fangchenli
DEPS: remove PY37 check from tests (pandas-dev#34472)
34d3e69
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 11, 2020
@fangchenli
DEPS: remove import (pandas-dev#34472)
8ec1d0b
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 11, 2020
@fangchenli
DEPS: remove PY37 in benchmark (pandas-dev#34472)
11c8654
@simonjayhawkins
Copy link
Member

looking at the number of downloads at https://anaconda.org/conda-forge/pandas/files i'm not convinced we should be doing this.

@jreback
Copy link
Contributor Author

jreback commented Jul 19, 2020

no we need to drop we are already supporting 3.9 and it's time

and most of that is likely city

@simonjayhawkins
Copy link
Member

simonjayhawkins commented Jul 19, 2020 •
edited
Loading

what about #34472 (comment)

I'm all for dropping 3.6 (and using some typing stuff from 3.7), just want to make sure it's the right thing to do.

@jreback
Copy link
Contributor Author

jreback commented Jul 19, 2020

the version policy is wrong
it should say minor

@simonjayhawkins simonjayhawkins mentioned this issue Jul 29, 2020
Merged
jreback pushed a commit that referenced this issue Aug 11, 2020
@fangchenli
Drop Python 3.6 support (#35214)
8380708 
* DEPS: drop 3.6 (#34472)

* DEPS: drop 3.6 (#34472)

* DEPS: fix file name (#34472)

* DEPS: fix import (#34472)

* DEPS: fix job name (#34472)

* DEPS: resolve min version conflicts (#34472)

* DEPS: fix env name (#34472)

* DEPS: remove py36 check in test, bump matplotlib (#34472)

* DEPS: fix travis 37 locale (#34472)

* DEPS: remove PY37 check from tests (#34472)

* DEPS: remove import (#34472)

* DEPS: remove PY37 in benchmark (#34472)

* try to fix timeout

* pytable version

* update minimum version

* remove xfail for test apply

* remove import

* try to fix timeout

* try to fix timeout

* try to fix timeout

* bump to 3.7.1 to fix timeout

* migrate ci

* fix env name

* remove py37-locale from azure

* resolve conflicts

* update ci

* update ci

* sync with master

* whatsnew and install doc

* whatsnew and install doc

* update environment.yml

* update environment.yml

* uncomment azure p37 locale

* move min pyarrow test

* bumpy numpy to 1.16.5

* bumpy numpy to 1.16.5

* fix 32bit

* comment out 32bit CI

* update numpy version in numpy/__init__.py

* remove import from numpy/__init__.py

* filter DeprecationWarning

* filter DeprecationWarning

* skip unreliable test for windows

* skip unreliable test for windows

* fix parameter order in docstring

* skip test

* skip test
@alessiamarcolini alessiamarcolini mentioned this issue Nov 18, 2020
Open
@lisphilar lisphilar mentioned this issue Jan 1, 2021
Closed
@de-code de-code mentioned this issue Jan 26, 2021
Closed
This was referenced Mar 4, 2021
Closed
Open
Closed
@xiki-tempula xiki-tempula mentioned this issue Jun 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dependencies Required and optional dependencies
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Drop Python 3.6 support fangchenli/pandas
3 participants
@jreback @simonjayhawkins @alimcmaster1