Skip to content

TST: slow test_nearest_upsample_with_limit with tzlocal #34413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue May 27, 2020 · 3 comments · Fixed by #34610
Closed

TST: slow test_nearest_upsample_with_limit with tzlocal #34413

jbrockmendel opened this issue May 27, 2020 · 3 comments · Fixed by #34610
Labels
Testing pandas testing functions or related to the test suite
Milestone

Comments

@jbrockmendel
Copy link
Member

Doing pytest pandas/tests --skip-slow --durations=10 the top two entries are

71.76s call     pandas/tests/resample/test_datetime_index.py::test_nearest_upsample_with_limit[tzlocal()-30S-Y]
59.86s call     pandas/tests/resample/test_datetime_index.py::test_nearest_upsample_with_limit[tzlocal()-30S-10M]

Because this uses the tz_aware_fixture, there isn't a trivial way to add a pytest.mark.slow to this, but figuring something out may be worthwhile.

@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels May 27, 2020
@dsaxton
Copy link
Member

dsaxton commented May 27, 2020

This test came up here #34131 and @jreback pointed out that it's resampling at probably too fine a frequency

@jbrockmendel
Copy link
Member Author

That and tzlocal is just slower than everything else in general. (ive got a branch implementing a cython equivalent i need to circle back to)

Could do something like:

@pytest.mark.slow
def test_foo_tzlocal():
    return thing(tzlocal)

def test_foo(tz_aware_fixture):
    if tz_aware_fixture is tzlocal:
         return/skip/whatever
    thing(tz_aware_fixture)

@jreback
Copy link
Contributor

jreback commented May 27, 2020

no easiest way is simple to split it into 2 tests and not try to upsample 1ms to 1y

jbrockmendel added a commit to jbrockmendel/pandas that referenced this issue Jun 5, 2020
@jbrockmendel jbrockmendel added Testing pandas testing functions or related to the test suite and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 6, 2020
@jreback jreback added this to the 1.1 milestone Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants