Skip to content

Performance regression in replace.ReplaceList.time_replace_list_one_match #34136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue May 12, 2020 · 0 comments · Fixed by #34737
Closed

Performance regression in replace.ReplaceList.time_replace_list_one_match #34136

TomAugspurger opened this issue May 12, 2020 · 0 comments · Fixed by #34737
Labels
Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Milestone
1.1

Comments

@TomAugspurger
Copy link
Contributor

TomAugspurger commented May 12, 2020 •
edited
Loading

https://pandas.pydata.org/speed/pandas/index.html#replace.ReplaceList.time_replace_list_one_match?p-inplace=False&commits=6388370eb313244ba0e4cd8215dcdbfdabb7004b-88d5f1264bf58b518b7cce39230d018db59b3c72 points to 6388370...88d5f12.

#34048 mentions DataFrame.replace. cc @simonjayhawkins.

https://pandas.pydata.org/speed/pandas/index.html#replace.FillNa.time_replace?p-inplace=True&commits=6388370eb313244ba0e4cd8215dcdbfdabb7004b-88d5f1264bf58b518b7cce39230d018db59b3c72 is probably the same cause.
@TomAugspurger TomAugspurger added Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version labels May 12, 2020
@TomAugspurger TomAugspurger added this to the 1.1 milestone May 12, 2020
@TomAugspurger TomAugspurger mentioned this issue Jun 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

PERF: avoid copy in replace TomAugspurger/pandas
1 participant
@TomAugspurger