Skip to content

BUG: Exceptions not propagated from c_is_list_like in lib.pyx #33721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shwina opened this issue Apr 22, 2020 · 2 comments · Fixed by #33723
Closed

BUG: Exceptions not propagated from c_is_list_like in lib.pyx #33721

shwina opened this issue Apr 22, 2020 · 2 comments · Fixed by #33723
Labels
Bug Segfault Non-Recoverable Error
Milestone
1.1

Comments

@shwina
Copy link
Contributor

shwina commented Apr 22, 2020

Python exceptions originating in c_is_list_like() are not propagated as the function doesn't declare an exception value (except -1).

https://github.com/pandas-dev/pandas/blob/master/pandas/_libs/lib.pyx#L988
@shwina shwina added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 22, 2020
shwina added a commit to shwina/pandas that referenced this issue Apr 22, 2020
@shwina
BUG: Propagate Python exceptions from c_is_list_like (pandas-dev#33721)
495f697
shwina added a commit to shwina/pandas that referenced this issue Apr 22, 2020
@shwina
BUG: Propagate Python exceptions from c_is_list_like (pandas-dev#33721)
da1f74a
@shwina shwina mentioned this issue Apr 22, 2020
Merged
5 tasks
@jbrockmendel
Copy link
Member

Can you give an example of where the problem shows up?

@shwina
Copy link
Contributor Author

shwina commented Apr 22, 2020 •
edited
Loading

@jbrockmendel Unfortunately I'm not able to reproduce easily at this moment. I left a comment here that hopefully sheds some light on the issue.

@jreback jreback added this to the 1.1 milestone Apr 27, 2020
@jreback jreback added Segfault Non-Recoverable Error and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 27, 2020
jreback pushed a commit that referenced this issue Apr 27, 2020
@shwina
BUG: Propagate Python exceptions from c_is_list_like (#33721) (#33723)
b828d74
rhshadrach pushed a commit to rhshadrach/pandas that referenced this issue May 10, 2020
@shwina @rhshadrach
BUG: Propagate Python exceptions from c_is_list_like (pandas-dev#33721)…
b92cc92 
… (pandas-dev#33723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Segfault Non-Recoverable Error
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

BUG: Propagate Python exceptions from c_is_list_like (#33721) shwina/pandas
3 participants
@jreback @shwina @jbrockmendel