Skip to content

CI: pandas warnings in tests about keyword only arguments #33397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Apr 8, 2020 · 0 comments · Fixed by #33482
Closed

CI: pandas warnings in tests about keyword only arguments #33397

TomAugspurger opened this issue Apr 8, 2020 · 0 comments · Fixed by #33482
Labels
Bug good first issue Testing pandas testing functions or related to the test suite Warnings Warnings that appear or should be added to pandas
Milestone
1.1

Comments

@TomAugspurger
Copy link
Contributor

e.g. https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=32821&view=logs&j=76104ccd-8dcc-5006-a17c-28bcdd709542&t=cd420693-444f-5c55-14e0-1be238e189a1

pandas\tests\io\test_html.py:886
  D:\a\1\s\pandas\tests\io\test_html.py:886: FutureWarning: Starting with Pandas version 2.0 all arguments of read_html except for the argument 'io' will be keyword-only
    result = self.read_html(data, "Arizona", index_col=0)[0]

We'll need to track down places where we're passing positional arguments like

pandas/pandas/tests/io/test_html.py

Line 886 in def6f6d

result = self.read_html(data, "Arizona", index_col=0)[0]
and update them to use keyword arguments. That may be the only one, not sure.
@TomAugspurger TomAugspurger added Bug Needs Triage Issue that has not been reviewed by a pandas team member good first issue Testing pandas testing functions or related to the test suite Warnings Warnings that appear or should be added to pandas and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 8, 2020
LTe added a commit to LTe/pandas that referenced this issue Apr 11, 2020
@LTe
Don't use eprecated version of read_html in tests
d1d33a9 
Usage of function read_html is marked as deprecated when used with
positional arguments. In case when we do not explicitly check the
warning message with assert_produces_warning we should use non-deprecated
version.

This will resolve pandas-dev#33397
LTe added a commit to LTe/pandas that referenced this issue Apr 11, 2020
@LTe
TST: Don't use eprecated version of read_html
c5b9942 
Usage of function read_html is marked as deprecated when used with
positional arguments. In case when we do not explicitly check the
warning message with assert_produces_warning we should use non-deprecated
version.

This will resolve pandas-dev#33397
@LTe LTe mentioned this issue Apr 11, 2020
Merged
5 tasks
LTe added a commit to LTe/pandas that referenced this issue Apr 11, 2020
@LTe
TST: Don't use deprecated version of read_html
9d745c8 
Usage of function read_html is marked as deprecated when used with
positional arguments. In case when we do not explicitly check the
warning message with assert_produces_warning we should use non-deprecated
version.

This will resolve pandas-dev#33397
@jreback jreback added this to the 1.1 milestone Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug good first issue Testing pandas testing functions or related to the test suite Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

TST: Don't use deprecated version of read_html LTe/pandas
2 participants
@jreback @TomAugspurger