Skip to content

DEPR: Remove aliased Resampler methods #33396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dsaxton opened this issue Apr 8, 2020 · 1 comment · Fixed by #45076
Closed

DEPR: Remove aliased Resampler methods #33396

dsaxton opened this issue Apr 8, 2020 · 1 comment · Fixed by #45076
Labels
Deprecate Functionality to remove in pandas Resample resample method
Milestone
1.4

Comments

@dsaxton
Copy link
Member

dsaxton commented Apr 8, 2020

It seems the forward and backward filling methods are duplicated for Resampler objects (e.g., bfill is an alias for backfill, and ffill is an alias for pad). Does it make sense to deprecate backfill and pad in favor of the bfill and ffill, as these names are more consistent with other methods in pandas (e.g., DataFrame.ffill)?
@dsaxton dsaxton added Needs Triage Issue that has not been reviewed by a pandas team member Usage Question Deprecate Functionality to remove in pandas Resample resample method and removed Needs Triage Issue that has not been reviewed by a pandas team member Usage Question labels Apr 8, 2020
@mroeschke mroeschke mentioned this issue Dec 27, 2021
Merged
4 tasks
@jreback jreback added this to the 1.4 milestone Dec 27, 2021
@rhshadrach
Copy link
Member

rhshadrach commented Oct 22, 2022 •
edited
Loading

It looks like pad / backfill were deprecated in groupby / Resampler, but not Series / DataFrame. I'm guessing it's desired to remove them in Series / DataFrame too? If that's the case, I'm wondering if we should deprecate them in Series / DataFrame in 2.x, leave them in groupby / Resampler (still deprecated), and remove everything altogether.

@phofl phofl mentioned this issue Feb 7, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Resample resample method
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

DEPR: resample/groupby.pad/backfill in favor of ffill/bfill mroeschke/pandas
3 participants
@jreback @dsaxton @rhshadrach