Skip to content

TST: Seemingly non-deterministic order of value_counts #32514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SaturnFromTitan opened this issue Mar 7, 2020 · 2 comments
Closed

TST: Seemingly non-deterministic order of value_counts #32514

SaturnFromTitan opened this issue Mar 7, 2020 · 2 comments
Assignees
@SaturnFromTitan
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Bug Testing pandas testing functions or related to the test suite

Comments

@SaturnFromTitan
Copy link
Contributor

We had a flaky test for test_value_counts in pandas/tests/base/test_ops.py which was related to the sort order of entries with the same count. A hotfix was introduced in #32449 and resolves the CI issue.

The underlying issue still isn't fixed/confirmed. The test assumes that in case of same counts the order of the original index/series object is preserved. This assumption breaks on CI though. Please refer to my comment (and the following ones) for all related details I have found so far.

It doesn't necessarily seem to be related to the narrow dtypes. It's probably just more likely that values are duplicated the narrower the dtype is.
@SaturnFromTitan SaturnFromTitan mentioned this issue Mar 7, 2020
Merged
@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Mar 7, 2020
@SaturnFromTitan
Copy link
Contributor Author

take

@mroeschke mroeschke added the Bug label May 22, 2020
@BaruchYoussin BaruchYoussin mentioned this issue Aug 23, 2020
Closed
1 task
@theemathas theemathas mentioned this issue Oct 6, 2020
Closed
3 tasks
@simonjayhawkins simonjayhawkins added the Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff label Jun 11, 2022
@mroeschke
Copy link
Member

Looks like this is not marked as flaky anymore so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaturnFromTitan SaturnFromTitan

Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Bug Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mroeschke @simonjayhawkins @SaturnFromTitan