Skip to content

Clean up null checking #32206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dsaxton opened this issue Feb 23, 2020 · 1 comment
Closed

Clean up null checking #32206

dsaxton opened this issue Feb 23, 2020 · 1 comment
Labels
API - Consistency Internal Consistency of API/Behavior Enhancement Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments

@dsaxton
Copy link
Member

dsaxton commented Feb 23, 2020 •
edited
Loading

From the discussion in #31939 it was pointed out that there are places where we check for nullness in an unnecessarily verbose way, e.g.: https://github.com/pandas-dev/pandas/blob/master/pandas/_libs/hashtable_class_helper.pxi.in#L1036.

Ideally we should just be able to use checknull from pandas/_libs/missing.pyx, but would need to make sure this catches all cases, such as decimal.Decimal("nan") (which I think isn't included at the moment).
@jorisvandenbossche jorisvandenbossche added API - Consistency Internal Consistency of API/Behavior Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Feb 24, 2020
@jbrockmendel jbrockmendel mentioned this issue Jan 26, 2021
Merged
4 tasks
jbrockmendel added a commit to jbrockmendel/pandas that referenced this issue Dec 26, 2021
@jbrockmendel
Fix docstring, use checknull, closes pandas-dev#32206
2b4499f
@jbrockmendel
Copy link
Member

closed by #45071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API - Consistency Internal Consistency of API/Behavior Enhancement Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jorisvandenbossche @dsaxton @jbrockmendel @mroeschke