Skip to content

Use sort fixture in more places #32183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SaturnFromTitan opened this issue Feb 22, 2020 · 1 comment · Fixed by #32292
Closed

Use sort fixture in more places #32183

SaturnFromTitan opened this issue Feb 22, 2020 · 1 comment · Fixed by #32292
Assignees
@SaturnFromTitan
Labels
Testing pandas testing functions or related to the test suite
Milestone
1.1

Comments

@SaturnFromTitan
Copy link
Contributor

This is a follow-up on this review comment by jbrockmendel.

There's a sort fixture in tests.indexes.interval.test_setops, which could be used in other places as well. For instance in test_difference_base in pandas/tests/indexes/common.py.

There are probably many more places where it could be used.
@SaturnFromTitan SaturnFromTitan mentioned this issue Feb 22, 2020
Merged
3 tasks
@charlesdong1991 charlesdong1991 added the Testing pandas testing functions or related to the test suite label Feb 23, 2020
@SaturnFromTitan
Copy link
Contributor Author

take

SaturnFromTitan added a commit to SaturnFromTitan/pandas that referenced this issue Feb 27, 2020
@SaturnFromTitan
[pandas-dev#32183] Use sort fixture in more places
e310dea
@SaturnFromTitan SaturnFromTitan mentioned this issue Feb 27, 2020
Merged
4 tasks
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaturnFromTitan SaturnFromTitan

Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

TST: Use sort fixture in more places SaturnFromTitan/pandas
3 participants
@charlesdong1991 @simonjayhawkins @SaturnFromTitan