-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix isort output in CI #30974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There are no already-existing settings in |
Ignoring that message sounds good, or any other solution. The only constraint is that we surely don't want to make that CI part much more complex. I'd prefer to just not have the |
I wouldn't mind giving this a go. From a very cursory double check on this, it does indeed appear that the most straightforward solution would be to catch the stdout from the command, and ignore when the output matches the undesired message. |
Hey |
The undocumented |
Excellent, thanks @d1618033 Do you want to open a pull request? |
- [x] closes pandas-dev#30974
- [x] closes pandas-dev#30974
In the CI, we're using
isort
to check whether the imports in Python files are sorted in an standard way. See https://github.com/pandas-dev/pandas/blob/master/ci/code_checks.sh#L114The way it is implemented, we expect isort to not print anything in the terminal if everything is ok, and to show errors for the errors encountered. This is mostly true, except that
isort
is also reporting when there are files being skipped.The result of this, is that we highlight in the CI as an error when there are files being skipped. See https://github.com/pandas-dev/pandas/pull/30946/checks?check_run_id=385833706#step:6:36
This can be misleading, and we should try to avoid it. Without adding much complexity to the already complex CI. Not sure if there is an
isort
parameter to simply not report the skipped files. Or if there is an easy way to not highlight the skipped files as an error.The text was updated successfully, but these errors were encountered: