-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
on master, pd.show_versions() emits a FutureWarning #30872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This seems to be due to a dependency on
@jorisvandenbossche I think you mentioned you were working on some parquet stuff, so maybe you are aware of this |
I've added the milestone, since I think this has only just appeared. (Can't be sure without checking) |
That's up to fastparquet to fix, not pandas (we are missing a stacklevel to make it clearer where it is coming from, though). Anybody wants to open an issue on the fastparquet tracker? |
@jorisvandenbossche you opened the issue about a month ago: dask/fastparquet#470 Having said that, since we ask people to use |
Ah, yes ;-) I don't have a strong opinion on filtering it in show_versions. On the one hand, it also signals problems (as you noticed now), on the other hand it gives warnings users can't do nothing about. |
@jorisvandenbossche I would suggest the following:
My sense is that the default should not emit the warnings so we don't get people wondering what is going on when they report issues. Separately, I'm guessing we could do some kind of regular thing in CI to do Also, given our discussion here, I've reopened this issue (you had closed it) so we can settle this point. |
I think we should just handle this in fastparquet. I'll make a PR. |
@TomAugspurger What if we start getting warnings from other libraries in the future as we deprecate more things in pandas? Shouldn't we do something in |
Seems like more hassle than it's worth. I'd rather get the underlying
libraries updated.
…On Mon, Jan 13, 2020 at 9:52 AM Irv Lustig ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> What if we start
getting warnings from other libraries in the future as we deprecate more
things in pandas? Shouldn't we do something in pd.show_versions()?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30872?email_source=notifications&email_token=AAKAOIXHS7UF57Y6JNJHR7LQ5SE43A5CNFSM4KE75ZJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZHFZY#issuecomment-573731559>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIUDASOVIUMVN7OBDFLQ5SE43ANCNFSM4KE75ZJA>
.
|
@TomAugspurger So now that you have patched fastparquet, they would need a new release, and do we need to update the version requirement in |
I don't think this merits bumping the minimum supported version.
…On Mon, Jan 13, 2020 at 10:16 AM Irv Lustig ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> So now that you have
patched fastparquet, they would need a new release, and do we need to
update the version requirement in pandas/compat/_optional.py at some
point?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30872?email_source=notifications&email_token=AAKAOIXOGDAX65JD23VRX5DQ5SHXPA5CNFSM4KE75ZJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZKE6Q#issuecomment-573743738>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIUEUQH45DBISY2XBDDQ5SHXPANCNFSM4KE75ZJA>
.
|
Since this has been long since fixed, probably okay to close now
|
Code Sample, a copy-pastable example if possible
Problem description
Gets this output:
followed by all the version stuff
Expected Output
No
FutureWarning
Output of
pd.show_versions()
C:\Code\pandas_dev\pandas36\pandas\core\index.py:29: FutureWarning: pandas.core.index is deprecated and will be removed in a future version. The public classes are available in the top-level namespace.
FutureWarning,
INSTALLED VERSIONS
commit : 7cce2c7
python : 3.6.7.final.0
python-bits : 64
OS : Windows
OS-release : 10
machine : AMD64
processor : Intel64 Family 6 Model 158 Stepping 13, GenuineIntel
byteorder : little
LC_ALL : None
LANG : None
LOCALE : None.None
pandas : 0.26.0.dev0+1739.g7cce2c7f4
numpy : 1.15.4
pytz : 2019.3
dateutil : 2.8.1
pip : 19.3.1
setuptools : 44.0.0.post20200102
Cython : 0.29.14
pytest : 5.3.2
hypothesis : 5.1.1
sphinx : None
blosc : None
feather : None
xlsxwriter : 1.2.7
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : 2.10.3
IPython : 7.11.1
pandas_datareader: None
bs4 : None
bottleneck : 1.3.1
fastparquet : 0.3.2
gcsfs : None
lxml.etree : None
matplotlib : 3.0.2
numexpr : 2.7.1
odfpy : None
openpyxl : 3.0.1
pandas_gbq : None
pyarrow : 0.14.1
pytables : None
pytest : 5.3.2
s3fs : None
scipy : 1.3.1
sqlalchemy : None
tables : 3.6.1
tabulate : None
xarray : None
xlrd : 1.2.0
xlwt : 1.3.0
xlsxwriter : 1.2.7
numba : 0.46.0
The text was updated successfully, but these errors were encountered: