Skip to content

TYPING: keywords in df.sort_values and sr.sort_values cannot be annotated #30451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
charlesdong1991 opened this issue Dec 24, 2019 · 3 comments
Closed

TYPING: keywords in df.sort_values and sr.sort_values cannot be annotated #30451

charlesdong1991 opened this issue Dec 24, 2019 · 3 comments
Labels
Closing Candidate May be closeable, needs more eyeballs Typing type annotations, mypy/pyright type checking

Comments

@charlesdong1991
Copy link
Member

Observed in the PR #30402 and PR #27237

Annotation seems not to be able to added for sort_values. If added, error message will pop up in CI:

pandas/core/series.py:2691: error: Signature of "sort_values" incompatible with supertype "NDFrame"
pandas/core/frame.py:4701: error: Signature of "sort_values" incompatible with supertype "NDFrame"
@charlesdong1991 charlesdong1991 mentioned this issue Dec 24, 2019
Merged
5 tasks
@jbrockmendel
Copy link
Member

To make the signatures match, by would need to be added to Series.sort_values

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Dec 28, 2019
@jacobaustin123
Copy link
Contributor

by would need to be added to Series.sort_values (as the first argument, so API breaking) and we would need to remove the default by=None argument in NDFrame.sort_values in generic.py.

@WillAyd WillAyd mentioned this issue Jan 3, 2020
Merged
4 tasks
@simonjayhawkins simonjayhawkins added API Design Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jan 3, 2020
@WillAyd WillAyd mentioned this issue Jan 7, 2020
Merged
@mzeitlin11 mzeitlin11 mentioned this issue Jan 10, 2021
Closed
@mroeschke mroeschke removed API Design Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jul 25, 2021
@jbrockmendel
Copy link
Member

These now have types, though there is a "type: ignore" on the DataFrame method. Closable?

@jbrockmendel jbrockmendel added the Closing Candidate May be closeable, needs more eyeballs label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closing Candidate May be closeable, needs more eyeballs Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jbrockmendel @charlesdong1991 @mroeschke @simonjayhawkins @jacobaustin123