Skip to content

Improve fname documentation for to_parquet #29476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
larroy opened this issue Nov 8, 2019 · 7 comments · Fixed by #33709
Closed

Improve fname documentation for to_parquet #29476

larroy opened this issue Nov 8, 2019 · 7 comments · Fixed by #33709
Labels
Docs IO Parquet parquet, feather

Comments

@larroy
Copy link
Contributor

larroy commented Nov 8, 2019

Code Sample, a copy-pastable example if possible

Should to_parquet without file behave the same way than to_json in which if no file is specified we return the buffer?

@TomAugspurger
Copy link
Contributor

Probably not, since parquet isn't a plaintext format.

@WillAyd
Copy link
Member

WillAyd commented Nov 8, 2019

Think I am agreed with Tom. Having all to_* functions return the same thing is also a non-goal, as it just doesn't make sense in all cases (to_sql comes to mind)

@WillAyd WillAyd closed this as completed Nov 8, 2019
@larroy
Copy link
Contributor Author

larroy commented Nov 8, 2019

Thanks for your answers.
It would still be useful to get the buffer without having to pass through the filesystem. Would a contribution in this direction be accepted? (At least for the functions that might make sense, ie. not for to_sql...)

@WillAyd WillAyd reopened this Nov 8, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 9, 2019

The documentation can be improved but you can pass an io.BytesIO object if you don't want to write to disk. I think path-like objects work as well - any interest in updating the docs?

@WillAyd WillAyd added Docs IO Parquet parquet, feather labels Nov 9, 2019
@WillAyd WillAyd changed the title consistent return on to_* functions Improve fname documentation for to_parquet Nov 9, 2019
@WillAyd WillAyd added this to the Contributions Welcome milestone Nov 9, 2019
@larroy
Copy link
Contributor Author

larroy commented Nov 9, 2019

Sure, I would be happy to update them. I will link the PRs here. Thank you.

@alimcmaster1
Copy link
Member

@larroy you still interested in working on this?

@larroy
Copy link
Contributor Author

larroy commented Apr 21, 2020

Sorry was caught up with other things, let me have a look at this this week.

larroy added a commit to larroy/pandas that referenced this issue Apr 21, 2020
larroy added a commit to larroy/pandas that referenced this issue Apr 22, 2020
larroy added a commit to larroy/pandas that referenced this issue Apr 22, 2020
larroy added a commit to larroy/pandas that referenced this issue Apr 22, 2020
larroy added a commit to larroy/pandas that referenced this issue Apr 24, 2020
larroy added a commit to larroy/pandas that referenced this issue Apr 24, 2020
larroy added a commit to larroy/pandas that referenced this issue Apr 26, 2020
larroy added a commit to larroy/pandas that referenced this issue May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO Parquet parquet, feather
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants