-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
pd.to_datetime should_cache errors with deque #29403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I suppose this should work as a |
Hi, Which would be better - to implement slicing for deque as well or return False from core.tools.datetimes.should_cache whenever a sequence is not slicable with [:] ? |
I think slicing the deque is preferable to not caching when the user passes a deque. Caching should be available for all inputs ideally. |
core.tools.datetimes.should_cache gives
sequence index must be integer, not 'slice
atunique(arg[:check_count])
if deque is not expected it would make more sense to give a better message, otherwise support?
looks like a "good first issue" ?
version 0.25+ (i think it works on 0.24 but i only tested 0.25)
The text was updated successfully, but these errors were encountered: