Skip to content

Move helper methods for Named Aggregation out of groupby/generic #28380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christopherzimmerman opened this issue Sep 11, 2019 · 3 comments
Closed

Move helper methods for Named Aggregation out of groupby/generic #28380

christopherzimmerman opened this issue Sep 11, 2019 · 3 comments
Labels
Refactor Internal refactoring of code

Comments

@christopherzimmerman
Copy link
Contributor

christopherzimmerman commented Sep 11, 2019 •
edited
Loading

Related to #28333 and #26513

There are several helper methods to help with named aggregations, that are found in pandas.core.groupby.generic, namely:

If this functionality gets standardized across aggregations other than just groupby, it would make sense to have these moved out of this file.
@WillAyd WillAyd added the Refactor Internal refactoring of code label Sep 11, 2019
@WillAyd
Copy link
Member

WillAyd commented Sep 11, 2019

Makes sense. I think would take a PR if you have something concrete to propose

@TomAugspurger

@TomAugspurger
Copy link
Contributor

Yeah. I'd recommend making a branch that does everything (moving the helpers, implementing NamedAgg for window), to prove things work, and then split the moving of helpers to its own PR.

@arpit1997 arpit1997 mentioned this issue Sep 16, 2019
Closed
@charlesdong1991 charlesdong1991 mentioned this issue Oct 20, 2019
Merged
5 tasks
@TomAugspurger TomAugspurger mentioned this issue Dec 6, 2019
Closed
@ghost ghost mentioned this issue Feb 28, 2020
Closed
@jbrockmendel
Copy link
Member

These now live in core.apply, closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@WillAyd @TomAugspurger @christopherzimmerman @jbrockmendel