Skip to content

seed isort known_third_party pre-commit hook #28236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Aug 30, 2019 · 0 comments · Fixed by #28272
Closed

seed isort known_third_party pre-commit hook #28236

TomAugspurger opened this issue Aug 30, 2019 · 0 comments · Fixed by #28272
Labels
CI Continuous Integration
Milestone
1.0.0

Comments

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 30, 2019 •
edited
Loading

@basnijholt question on this. When making changes in #28164, seed_isort_known_third_party wants to make the following changes.

diff --git a/setup.cfg b/setup.cfg
index 43dbac15f5..227defcfe8 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -116,7 +116,7 @@ known_dtypes = pandas.core.dtypes
 known_post_core = pandas.tseries,pandas.io,pandas.plotting
 sections = FUTURE,STDLIB,THIRDPARTY,PRE_LIBS,PRE_CORE,DTYPES,FIRSTPARTY,POST_CORE,LOCALFOLDER
 known_first_party = pandas
-known_third_party = _pytest,announce,dateutil,docutils,flake8,git,hypothesis,jinja2,lxml,matplotlib,numpy,numpydoc,pkg_resources,pyarrow,pytest,pytz,requests,scipy,setuptools,sphinx,sqlalchemy,validate_docstrings,yaml
+known_third_party = announce,dateutil,docutils,flake8,git,hypothesis,jinja2,lxml,matplotlib,numpy,numpydoc,pkg_resources,pyarrow,pytest,pytz,requests,scipy,setuptools,sphinx,sqlalchemy,validate_docstrings,yaml
 multi_line_output = 3
 include_trailing_comma = True
 force_grid_wrap = 0

Is that expected? It also takes quite a while to run (5ish seconds). Is that expected?
TomAugspurger added a commit to TomAugspurger/pandas that referenced this issue Sep 3, 2019
@TomAugspurger
DEV: Remove seed-isort-config hook
f8d1c11 
This was causing issues for me locally. Anyone else?

It took a while to run, and didn't seem to give the same
output as others (depends on something peculiar to my environment)
which doesn't seem to be great for a pre-commit hook.

Closes pandas-dev#28236
TomAugspurger added a commit to TomAugspurger/pandas that referenced this issue Sep 3, 2019
@TomAugspurger
DEV: Remove seed-isort-config hook
483fa83 
This was causing issues for me locally. Anyone else?

It took a while to run, and didn't seem to give the same
output as others (depends on something peculiar to my environment)
which doesn't seem to be great for a pre-commit hook.

Closes pandas-dev#28236
@TomAugspurger TomAugspurger mentioned this issue Sep 3, 2019
Merged
@jreback jreback added this to the 1.0 milestone Sep 4, 2019
@jreback jreback added the CI Continuous Integration label Sep 4, 2019
jreback pushed a commit that referenced this issue Sep 4, 2019
@TomAugspurger @jreback
DEV: Remove seed-isort-config hook (#28272)
243c1bc 
This was causing issues for me locally. Anyone else?

It took a while to run, and didn't seem to give the same
output as others (depends on something peculiar to my environment)
which doesn't seem to be great for a pre-commit hook.

Closes #28236
proost pushed a commit to proost/pandas that referenced this issue Dec 19, 2019
@TomAugspurger @proost
DEV: Remove seed-isort-config hook (pandas-dev#28272)
034c362 
This was causing issues for me locally. Anyone else?

It took a while to run, and didn't seem to give the same
output as others (depends on something peculiar to my environment)
which doesn't seem to be great for a pre-commit hook.

Closes pandas-dev#28236
proost pushed a commit to proost/pandas that referenced this issue Dec 19, 2019
@TomAugspurger @proost
DEV: Remove seed-isort-config hook (pandas-dev#28272)
a09b840 
This was causing issues for me locally. Anyone else?

It took a while to run, and didn't seem to give the same
output as others (depends on something peculiar to my environment)
which doesn't seem to be great for a pre-commit hook.

Closes pandas-dev#28236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

DEV: remove seed isort config TomAugspurger/pandas
2 participants
@jreback @TomAugspurger