Skip to content

CI checks doesn't catch commit subject whitespace errors #27345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Jul 11, 2019 · 3 comments
Closed

CI checks doesn't catch commit subject whitespace errors #27345

ghost opened this issue Jul 11, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Jul 11, 2019

$ git log --format="%s" | head -n 10
CLN: revisit build warnings in cython templates
 ENH: Raise ValueError for unsupported Window functions (#27275)
BUG: fix inserting tz-aware datetime to Series, closes #12862 (#27322)
CLN: requested follow-ups (#27332)
BUG: Consistent division by zero behavior for Index/Series (#27321)
TST: suppress rolling warnings correctly for raw= (#27330)
CLN: replace usage internally of .iteritems with .items (#26114)
BUG: appending a Timedelta to Series incorrectly casts to integer (#27303)
CLN: Split test_window.py (#27305)
check early for non-scalar default_fill_value (#27302)
$ git log --format="%s" | grep "^ " | wc -l
44

There are multiple recent instances.

@WillAyd
Copy link
Member

WillAyd commented Jul 11, 2019

Is this a common thing to check for?

@jorisvandenbossche
Copy link
Member

How would it be checked? If you have multiple commits, the commit message comes from the github PR title. So you would need a github app / bot that checks that.

@jorisvandenbossche
Copy link
Member

So where did the leading space come from?

No idea, but if not from the PR title and not from the commit message, then human error when merging is the only thing I can think of. And we will not be able to have a CI check for human error ;)

@ghost ghost closed this as completed Jul 12, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants