Skip to content

Annotate DataFrame (API exposed items from pandas.core.api) #26792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 4 tasks
vaibhavhrt opened this issue Jun 11, 2019 · 5 comments
Closed
2 of 4 tasks

Annotate DataFrame (API exposed items from pandas.core.api) #26792

vaibhavhrt opened this issue Jun 11, 2019 · 5 comments
Labels
Typing type annotations, mypy/pyright type checking

Comments

@vaibhavhrt
Copy link
Contributor

vaibhavhrt commented Jun 11, 2019

Part of #26766

  • _constructor
  • _constructor_expanddim
  • __init__
  • axes
  • shape
  • _is_homogeneous_type
  • _repr_fits_vertical_
  • _repr_fits_horizontal_
  • _info_repr
  • __repr__
  • _repr_html_
  • to_string
  • style
  • items
  • iteritems
  • iterrows
  • itertuples
  • __len__
  • dot
  • __matmul__
  • __rmatmul__
  • Part 4 (IO methods)
  • from_dict
  • to_numpy
  • to_dict
  • to_gbq
  • from_records
  • to_records
  • from_items
  • _from_arrays
  • to_stata
  • to_feather
  • to_parquet
  • to_html
@vaibhavhrt
Copy link
Contributor Author

PR coming soon

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Jun 11, 2019
@WillAyd
Copy link
Member

WillAyd commented Jun 13, 2019

This is probably tough to do in one pass. If you want to break up into a few PRs that should work too

@vaibhavhrt
Copy link
Contributor Author

Yeah it will be nice. PR with large changes are hard to review and debug. I am kinda busy these days but I will get to it soon.

@vaibhavhrt
Copy link
Contributor Author

Whew it's a big one ~8k lines class. I will annotate all the @property methods on top of class first. The methods of the class are grouped using comments(eg. Rendering Methods, etc.), I will pick one group at a time in one PR.

@jbrockmendel
Copy link
Member

closing a mostly-duplicate of #26766. if you want to take this back up, let's put the checkboxes in a sublist over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants