Skip to content

PLOT: Split plotting tests #26745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datapythonista opened this issue Jun 8, 2019 · 3 comments
Closed

PLOT: Split plotting tests #26745

datapythonista opened this issue Jun 8, 2019 · 3 comments
Labels
Clean Testing pandas testing functions or related to the test suite Visualization plotting

Comments

@datapythonista
Copy link
Member

#26414 splitted the pandas plotting code into two different modules:

  • pandas.plotting: Generic plotting framework that defined an API (with docs) and is able to plot with a selectable backend (will be selectable with a pandas option)
  • pandas.plotting._matplotlib: Matplotlib backend

Our tests in pandas/tests/plotting are currently testing both together (calling the pandas plotting framework, which will call the matplotlib backend). But ideally we'd like to have two different groups of tests:

  • One with the current code but calling the matplotlib backend directly
  • A test set of the generic pandas plotting framework, using a mock backend (needs to be implemented)

@jreback let me know if this makes sense to you

@datapythonista datapythonista added Testing pandas testing functions or related to the test suite Visualization plotting labels Jun 8, 2019
@jorisvandenbossche
Copy link
Member

One with the current code but calling the matplotlib backend directly

Why should we need to call the matplotlib backend directly instead of keep testing it through the user-facing API?

@jbrockmendel
Copy link
Member

@datapythonista is this still worth pursuing?

@datapythonista
Copy link
Member Author

@datapythonista is this still worth pursuing?

Probably not, thanks for triagging this. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Development

No branches or pull requests

4 participants