Skip to content

Broken benchmarks #26709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datapythonista opened this issue Jun 7, 2019 · 2 comments · Fixed by #26711 or #26712
Closed

Broken benchmarks #26709

datapythonista opened this issue Jun 7, 2019 · 2 comments · Fixed by #26711 or #26712
Labels
Benchmark Performance (ASV) benchmarks CI Continuous Integration Interval Interval data type

Comments

@datapythonista
Copy link
Member

The benchmarks are currently broken, and are making red the CI of all PRs that modify something in asv_bench (we run the CI check for benchmarks when something is modified in that directory).

This has probably been caused by #26225. But it's strange that the CI for that PR wasn't red, since it run the benchmark checks.

This is blocking #26414, #26703. The error can be seen here: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=12407

[ 16.10%] ··· ...ervalIndexMethod.time_intersection_duplicate         1/3 failed
[ 16.10%] ··· ========== ==========
                param1             
              ---------- ----------
                 1000     1.76±0ms 
                100000    73.3±0ms 
               10000000    failed  
              ========== ==========
@datapythonista datapythonista added CI Continuous Integration Interval Interval data type Benchmark Performance (ASV) benchmarks labels Jun 7, 2019
@TomAugspurger
Copy link
Contributor

Taking a look now.

@qwhelan
Copy link
Contributor

qwhelan commented Jun 7, 2019

It appears this large N never worked. I have a fix that yields a large speedup (~10x+) but possibly changes the intent of this benchmark: #26711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks CI Continuous Integration Interval Interval data type
Projects
None yet
3 participants