Skip to content

Add Annotations to assert_*_equal functions #26302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WillAyd opened this issue May 7, 2019 · 3 comments
Closed

Add Annotations to assert_*_equal functions #26302

WillAyd opened this issue May 7, 2019 · 3 comments
Labels
Testing pandas testing functions or related to the test suite Typing type annotations, mypy/pyright type checking

Comments

@WillAyd
Copy link
Member

WillAyd commented May 7, 2019

Follow up to #25462 (comment) want to add annotations for parameters.

Would ideally probably want to add NoReturn but that requires 3.5.4 at a minimum so may want to explore other options

@WillAyd WillAyd added Testing pandas testing functions or related to the test suite Typing type annotations, mypy/pyright type checking labels May 7, 2019
@WillAyd WillAyd added this to the Contributions Welcome milestone May 7, 2019
@samuelsinayoko
Copy link
Contributor

Am going to try and pick this one up. Am interested to help with mypy and I have worked on assert utils as part of #25462 (comment).

@jreback jreback modified the milestones: Contributions Welcome, 1.0 Nov 13, 2019
@jreback jreback modified the milestones: 1.0, Contributions Welcome Jan 1, 2020
@avinashpancham
Copy link
Contributor

avinashpancham commented Jan 31, 2021

made an overview of the functions in _testing/asserters.py. I will start with assert_frame_equal and assert_series_equal. Issue seems like a good first issue

  • assert_almost_equal
  • assert_dict_equal
  • assert_index_equal
  • assert_class_equal
  • assert_attr_equal
  • assert_categorical_equal
  • assert_interval_array_equal
  • assert_period_array_equal
  • assert_datetime_array_equal
  • assert_timedelta_array_equal
  • assert_numpy_array_equal
  • assert_extension_array_equal
  • assert_series_equal
  • assert_frame_equal
  • assert_equal
  • assert_sp_array_equal

@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@mroeschke
Copy link
Member

I see a lot of these methods are typed now so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants