Skip to content

Fix type annotations in pandas.plotting._core #26020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gwrome opened this issue Apr 7, 2019 · 0 comments
Closed

Fix type annotations in pandas.plotting._core #26020

gwrome opened this issue Apr 7, 2019 · 0 comments
Labels
Typing type annotations, mypy/pyright type checking
Milestone
0.25.0

Comments

@gwrome
Copy link
Contributor

gwrome commented Apr 7, 2019

Part of #25882

pandas.plotting._core currently has these errors:

pandas/plotting/_core.py:958: error: Incompatible types in assignment (expression has type "str", base class "MPLPlot" defined the type as "None")
pandas/plotting/_core.py:1177: error: Incompatible types in assignment (expression has type "str", base class "MPLPlot" defined the type as "None")
pandas/plotting/_core.py:1728: error: "type" has no attribute "_kind"
gwrome added a commit to gwrome/pandas that referenced this issue Apr 7, 2019
@gwrome
pandas-dev#26020 Fixed type annotations for pandas.plotting._core
c9ff68f
@gwrome gwrome mentioned this issue Apr 7, 2019
Merged
4 tasks
@jreback jreback added the Typing type annotations, mypy/pyright type checking label Apr 7, 2019
@jreback jreback added this to the 0.25.0 milestone Apr 7, 2019
WillAyd pushed a commit that referenced this issue Apr 8, 2019
@gwrome @WillAyd
#26020 Fixed type annotations for pandas.plotting._core (#26021)
0610a60
@gwrome gwrome closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
0.25.0
Development

No branches or pull requests
2 participants
@jreback @gwrome