Skip to content

Fix Type Annotations in pandas/_version.py #25948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vaibhavhrt opened this issue Apr 1, 2019 · 1 comment · Fixed by #25949
Closed

Fix Type Annotations in pandas/_version.py #25948

vaibhavhrt opened this issue Apr 1, 2019 · 1 comment · Fixed by #25949
Labels
Typing type annotations, mypy/pyright type checking
Milestone
0.25.0

Comments

@vaibhavhrt
Copy link
Contributor

Part of #25882

Current errors are as follows:

pandas\_version.py:51: error: Need type annotation for 'LONG_VERSION_PY'
pandas\_version.py:52: error: Need type annotation for 'HANDLERS'
@vaibhavhrt
Copy link
Contributor Author

vaibhavhrt commented Apr 1, 2019 •
edited
Loading

@WillAyd I have decided to start from top in mypy.ini so here is the first one. please tag label, project and milestone for it because I don't have access to it.

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Apr 1, 2019
@vaibhavhrt vaibhavhrt mentioned this issue Apr 1, 2019
Merged
4 tasks
@jreback jreback added this to the 0.25.0 milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Fix type annotation in pandas. version vaibhavhrt/pandas
3 participants
@WillAyd @jreback @vaibhavhrt