Skip to content

Fix PyDateTime_CheckExact checks as proxy for Timestamp checks in cython files #25851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ArtificialQualia opened this issue Mar 23, 2019 · 0 comments · Fixed by #25853
Closed

Fix PyDateTime_CheckExact checks as proxy for Timestamp checks in cython files #25851

ArtificialQualia opened this issue Mar 23, 2019 · 0 comments · Fixed by #25853
Labels
Datetime Datetime data dtype Internals Related to non-user accessible pandas implementation
Milestone
0.25.0

Comments

@ArtificialQualia
Copy link
Contributor

This is a followup to the discussion in #25746.

PyDateTime_CheckExact is being used as a proxy for isinstance(obj, Timestamp) checks for performance reasons. However, if a subclass of the std datetime lib is being used, these checks are not sufficient to determine if an object is a Timestamp or not. Thus a performant replacement must be found.

I have a working fix, but need to do some more performance testing and add proper test cases. If that goes well, I will submit a PR for this.
ArtificialQualia added a commit to ArtificialQualia/pandas that referenced this issue Mar 23, 2019
@ArtificialQualia
BUG: Fix Timestamp type checks to work with subclassed datetime (pand…
2e5a160 
…as-dev#25851)
@ArtificialQualia ArtificialQualia mentioned this issue Mar 23, 2019
Merged
4 tasks
@gfyoung gfyoung added Datetime Datetime data dtype Internals Related to non-user accessible pandas implementation labels Mar 25, 2019
@jreback jreback added this to the 0.25.0 milestone Apr 5, 2019
jreback pushed a commit that referenced this issue Apr 5, 2019
@ArtificialQualia @jreback
BUG: Fix Timestamp type checks to work with subclassed datetime (#25851…
181f972 
…) (#25853)
@pganssle pganssle mentioned this issue Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Datetime Datetime data dtype Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

BUG: Fix Timestamp type checks to work with subclassed datetime (#25851) ArtificialQualia/pandas
3 participants
@jreback @gfyoung @ArtificialQualia