Skip to content

ERR: excel styler tests failing recently #25351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Feb 17, 2019 · 6 comments · Fixed by #41995
Closed

ERR: excel styler tests failing recently #25351

jreback opened this issue Feb 17, 2019 · 6 comments · Fixed by #41995
Labels
IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail

Comments

@jreback
Copy link
Contributor

jreback commented Feb 17, 2019

https://travis-ci.org/pandas-dev/pandas/jobs/494493327

xref @jnothman

@jreback jreback added Testing pandas testing functions or related to the test suite IO Excel read_excel, to_excel Code Style Code style, linting, code_checks labels Feb 17, 2019
@jreback jreback added this to the 0.25.0 milestone Feb 17, 2019
@jnothman
Copy link
Contributor

jnothman commented Feb 17, 2019 via email

@jreback
Copy link
Contributor Author

jreback commented Feb 17, 2019

no on that CI

look on the one i linked

or just pull master and run the test (i installed latest openpyxl)

@jnothman
Copy link
Contributor

jnothman commented Feb 17, 2019 via email

@jnothman
Copy link
Contributor

jnothman commented Feb 19, 2019 via email

@jreback jreback modified the milestones: 0.25.0, Contributions Welcome May 12, 2019
@jbrockmendel jbrockmendel removed the Code Style Code style, linting, code_checks label Oct 16, 2019
@jbrockmendel jbrockmendel added the Unreliable Test Unit tests that occasionally fail label Dec 20, 2019
@mroeschke
Copy link
Member

Dont think we've been seeing this test fail in the CI recently. Might have been a dependency bump that fixed this. Closing but we can reopen if we see it again

@attack68
Copy link
Contributor

Reopening.
The tests for styler.to_excel all xfail - this was added to get CI working but the test is pointless since the function is actually broken (e.g. border styles bug on #42276).

I need to add a test for #41995, so I will see if I can patch these, or at least get some useful tests in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants