TST: psycopg2 errors when running tests locally

[jbrockmendel]

I just started noticing these (167 of them) in the logs from python -m pytest pandas/tests --skip-slow

_____________________________ ERROR at setup of TestPostgreSQLAlchemyConn.test_read_sql[load_iris_data0] ______________________________

cls = <pandas.tests.io.test_sql.TestPostgreSQLAlchemyConn object at 0x7f2843ab4a50>

    @pytest.fixture(autouse=True, scope='class')
    def setup_class(cls):
        cls.setup_import()
        cls.setup_driver()
        conn = cls.connect()
>       conn.connect()

[...]
>       conn = _connect(dsn, connection_factory=connection_factory, async=async)
E       OperationalError: (psycopg2.OperationalError) fe_sendauth: no password supplied

../../.local/lib/python2.7/site-packages/psycopg2/__init__.py:164: OperationalError

[jbrockmendel]

Looking at setup.cfg, I guess I'm supposed to start specifying --skip-db too?

[TomAugspurger]

Skipping should probably be the default, right @datapythonista?

[datapythonista]

I thought about it, but as pymysql and psycopg are not in environment.yml, I didn't see a difference, as the tests should be skipped anyway.

Happy to change it, I don't have a preference.

[TomAugspurger]

I'd prefer skipping but default (but failing if the db tests are requested and don't get setup correctly). I know that I have pyscopg2 installed in my dev env, but don't have the expected databases setup right now.

…

On Sat, Dec 29, 2018 at 2:19 PM Marc Garcia ***@***.***> wrote: I thought about it, but as pymysql and psycopg are not in environment.yml, I didn't see a difference, as the tests should be skipped anyway. Happy to change it, I don't have a preference. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24485 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIrNIswmqe_-tEAL2uxwR70aJbeW5ks5u985dgaJpZM4Zkpg3> .

[datapythonista]

ok, will open a PR

[jbrockmendel]

So I'm now getting 242 errors, at runtime, most/all of which appear to be in pandas/tests/io/test_sql.py. The error message I'm seeing is weird:

______________________________ ERROR at setup of TestSQLiteAlchemyConn.test_transactions[load_iris_data0] _______________________________

item = <Function 'test_transactions[load_iris_data0]'>

    def pytest_runtest_setup(item):
        if 'slow' in item.keywords and item.config.getoption("--skip-slow"):
            pytest.skip("skipping due to --skip-slow")
    
        if 'slow' not in item.keywords and item.config.getoption("--only-slow"):
            pytest.skip("skipping due to --only-slow")
    
        if 'network' in item.keywords and item.config.getoption("--skip-network"):
            pytest.skip("skipping due to --skip-network")
    
        if 'high_memory' in item.keywords and not item.config.getoption(
                "--run-high-memory"):
            pytest.skip(
                "skipping high memory test since --run-high-memory was not set")
    
        # if "db" not explicitly set in the -m pattern, we skip the db tests
        if 'db' in item.keywords:
            pattern = item.config.getoption('-m')
            markers = collections.defaultdict(bool)
            for marker in item.iter_markers():
                markers[marker.name] = True
            markers['db'] = False
>           db_in_pattern = not eval(pattern, {}, markers)
E             File "<string>", line 0
E               
E              ^
E           SyntaxError: unexpected EOF while parsing

pandas/conftest.py:70: SyntaxError

Any chance this is related to #24492?

[datapythonista]

Sorry. Yes, just realized now. I tested it with different values for the -m parameter, but didn't test when -m is not provided (and the CI also has it).

Will open a PR soon.

[datapythonista]

Opened #24513