-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Stale Bot for Old Issues and PR's? #23489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 for something like this! |
I’ve never been a fan of these bots when your issue is the one being closed. Do you know if it can be configured to only do pull requests? We have a big backlog of real issues, that just aren’t a priority.
…________________________________
From: gfyoung <[email protected]>
Sent: Sunday, November 4, 2018 5:40:27 AM
To: pandas-dev/pandas
Cc: Tom Augspurger; Team mention
Subject: [pandas-dev/pandas] Stale Bot for Old Issues and PR's? (#23489)
https://probot.github.io/apps/stale/
cc @pandas-dev/pandas-core<https://github.com/orgs/pandas-dev/teams/pandas-core>
(looking at you @jreback<https://github.com/jreback> in particular, given the herculean task you periodically undertake of closing and pinging stale PR's for further work or rebasing)
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub<#23489>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIjXErAKM3t3YPD6WNr_HaA-89rKLks5urtIrgaJpZM4YNQdA>.
|
@TomAugspurger looking at the docs it can be limited to just PRs with something like: # Limit to only `issues` or `pulls`
# only: pulls |
I'm -1 on this. For the PRs labeled with "Docs" or "Style" (around one quarter of the total), the ones I usually monitor, I wouldn't like any bot to label them as stale or close it. The ones I think they are worth closing it doesn't give me any work to close. And it'd be annoying to have to reopen soon (there are many old ones that there is work going on, or I want to finish myself). |
we could configure this to act in a limited fashion |
Another potential option out there is gitmate which has features like automatic label setting and finding duplicate issues - I don't have any first hand experience of using it -but could potentially be useful. |
In response to many of the comments, I agree with @jreback that we can use it in a limited fashion. For starters, there is a lag between when the bot adds the @datapythonista : I think that would address your concern of having to constantly reopen them, as the bot would not close the PR for awhile but we would still get the advantage of pinging people. |
Given the pushback, I'll close this. Perhaps another day, another time. 🙂 |
https://probot.github.io/apps/stale/
cc @pandas-dev/pandas-core
(looking at you @jreback in particular, given the herculean task you periodically undertake of closing and pinging stale PR's for further work or rebasing)
xref PR Management Email Chain (internal)
The text was updated successfully, but these errors were encountered: