Skip to content

Gaps in ExtensionArray test coverage #23241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Oct 19, 2018 · 4 comments
Closed

Gaps in ExtensionArray test coverage #23241

TomAugspurger opened this issue Oct 19, 2018 · 4 comments
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. good first issue Needs Tests Unit test(s) needed to prevent regressions Testing pandas testing functions or related to the test suite
Milestone
0.24.0

Comments

@TomAugspurger
Copy link
Contributor

We need tests that assert

  1. fillna raises when passed an array of the wrong length
  2. fillna returns a copy when there are no missing value
  3. take raises when passed an invalid object for fill_value (may be somewhat tricky to do in a base test).

These tests would go in https://github.com/pandas-dev/pandas/blob/master/pandas/tests/extension/base/methods.py and https://github.com/pandas-dev/pandas/blob/master/pandas/tests/extension/base/getitem.py
@TomAugspurger TomAugspurger added Testing pandas testing functions or related to the test suite Effort Low good first issue ExtensionArray Extending pandas with custom dtypes or arrays. Needs Tests Unit test(s) needed to prevent regressions labels Oct 19, 2018
@TomAugspurger TomAugspurger added this to the Contributions Welcome milestone Oct 19, 2018
@thoo
Copy link
Contributor

thoo commented Oct 19, 2018

@TomAugspurger I am going to work on this.

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Oct 19, 2018 via email

@thoo
Copy link
Contributor

thoo commented Oct 19, 2018

@TomAugspurger Thanks.

@thoo thoo mentioned this issue Oct 21, 2018
Merged
@thoo
Copy link
Contributor

thoo commented Oct 21, 2018

@TomAugspurger It is not done yet. I just want to make sure I am on the right track. Could you please take a look? Thanks.

@jreback jreback modified the milestones: Contributions Welcome, 0.24.0 Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. good first issue Needs Tests Unit test(s) needed to prevent regressions Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

No branches or pull requests
3 participants
@jreback @TomAugspurger @thoo