-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix the docstring of resample in pandas/core/generic.py #22894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can work on this! |
I would like to work on this |
Great, let us know if you need help @martharobinson Now we've got few PRs from others that can help you, as they are quite similar: #22902, #22890, #22904 and #22906 |
Hey @datapythonista as the last person who volunteered didn't eventually open a PR I took a stab at this and made good progress during the London Python Sprints Hacktoberfest meetup, hope I didn't break any I have a question. The Thanks! |
In some cases it may make sense to ping the last person who said would be working on it. But an issue to fix a docstring with no activity for two weeks seems like available to me too. Deprecated parameters should be documented and have the sphinx directive for deprecations. |
Yes, sorry life intervened and prevented me from finishing this! Sorry for not making that clear. |
* First iteration over some validation errors on pandas.Series.resample. * Fix multi-line examples issue.
Not too sure they were deprecated from v0.18.0. Need to point this out in the PR.
Raised #23197. Some of the CI tests were failing, particularly re: py27, should I also fix these before the review? |
… convention examples. (pandas-dev#22894)
…er and other cosmetical mods. (pandas-dev#22894)
pandas docstring are expected to follow the format defined in https://pandas.pydata.org/pandas-docs/stable/contributing_docstring.html
This includes among other things:
transformed : Series
) but just the type (e.g.Series
) in the first line.We should make the required adjustments in the docstring of the function
resample
inpandas/core/generic.py
.We should validate the docstring with our validator (which does not validate all the formats, but some):
./scripts/validate_docstrings.py pandas.Series.resample
And we should validate the PEP-8 of the examples (note that the next command will validate the PEP-8 of all examples, just make sure that none of the shown is in the function being addressed, the rest will be fixed in separate issues):
flake8 --doctests pandas/core/generic.py
The text was updated successfully, but these errors were encountered: